OSDN Git Service

dmaengine: ppc4xx: remove xor_hw_desc assignment without reading
authorKrzysztof Kozlowski <krzk@kernel.org>
Mon, 19 Oct 2020 15:57:56 +0000 (17:57 +0200)
committerVinod Koul <vkoul@kernel.org>
Fri, 30 Oct 2020 08:40:27 +0000 (14:10 +0530)
The xor_hw_desc local variable is assigned but never read:

    drivers/dma/ppc4xx/adma.c: In function ‘ppc440spe_desc_set_src_mult’:
    drivers/dma/ppc4xx/adma.c:562:17: warning: variable ‘xor_hw_desc’ set but not used [-Wunused-but-set-variable]

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20201019155756.21445-2-krzk@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/ppc4xx/adma.c

index fea5985..df77040 100644 (file)
@@ -559,7 +559,6 @@ static void ppc440spe_desc_set_src_mult(struct ppc440spe_adma_desc_slot *desc,
                        int sg_index, unsigned char mult_value)
 {
        struct dma_cdb *dma_hw_desc;
-       struct xor_cb *xor_hw_desc;
        u32 *psgu;
 
        switch (chan->device->id) {
@@ -590,7 +589,6 @@ static void ppc440spe_desc_set_src_mult(struct ppc440spe_adma_desc_slot *desc,
                *psgu |= cpu_to_le32(mult_value << mult_index);
                break;
        case PPC440SPE_XOR_ID:
-               xor_hw_desc = desc->hw_desc;
                break;
        default:
                BUG();