OSDN Git Service

watchdog: JZ4740: Disable clock after stopping counter
authorPaul Cercueil <paul@crapouillou.net>
Thu, 10 May 2018 18:47:44 +0000 (20:47 +0200)
committerJames Hogan <jhogan@kernel.org>
Mon, 14 May 2018 22:58:23 +0000 (23:58 +0100)
Previously, the clock was disabled first, which makes the watchdog
component insensitive to register writes.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
Cc: Mathieu Malaterre <malat@debian.org>
Cc: linux-watchdog@vger.kernel.org
Cc: linux-mips@linux-mips.org
Signed-off-by: James Hogan <jhogan@kernel.org>
drivers/watchdog/jz4740_wdt.c

index aafbeb9..55c9a1f 100644 (file)
@@ -124,8 +124,8 @@ static int jz4740_wdt_stop(struct watchdog_device *wdt_dev)
 {
        struct jz4740_wdt_drvdata *drvdata = watchdog_get_drvdata(wdt_dev);
 
-       jz4740_timer_disable_watchdog();
        writeb(0x0, drvdata->base + JZ_REG_WDT_COUNTER_ENABLE);
+       jz4740_timer_disable_watchdog();
 
        return 0;
 }