OSDN Git Service

drivers: net: smc91x: remove redundant initialization of pointer gpio
authorColin Ian King <colin.king@canonical.com>
Fri, 26 Mar 2021 19:28:47 +0000 (19:28 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 29 Mar 2021 00:51:17 +0000 (17:51 -0700)
The pointer gpio is being initialized with a value that is
never read and it is being updated later with a new value. The
initialization is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/smsc/smc91x.c

index 891b492..cbde83f 100644 (file)
@@ -2204,7 +2204,7 @@ static int try_toggle_control_gpio(struct device *dev,
                                   const char *name, int index,
                                   int value, unsigned int nsdelay)
 {
-       struct gpio_desc *gpio = *desc;
+       struct gpio_desc *gpio;
        enum gpiod_flags flags = value ? GPIOD_OUT_LOW : GPIOD_OUT_HIGH;
 
        gpio = devm_gpiod_get_index_optional(dev, name, index, flags);