OSDN Git Service

cxgb4: remove set but not used variables 'multitrc, speed'
authorYueHaibing <yuehaibing@huawei.com>
Sat, 24 Nov 2018 10:36:21 +0000 (18:36 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sun, 25 Nov 2018 01:37:17 +0000 (17:37 -0800)
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:5883:6:
 warning: variable 'multitrc' set but not used [-Wunused-but-set-variable]

drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:8585:32:
 warning: variable 'speed' set but not used [-Wunused-but-set-variable]

'multitrc' never used since introduction in
commit 8e3d04fd7d70 ("cxgb4: Add MPS tracing support")

'speed' never used since introduction in
commit c3168cabe1af ("cxgb4/cxgbvf: Handle 32-bit fw port capabilities")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/chelsio/cxgb4/t4_hw.c

index 4cb261d..e8c3429 100644 (file)
@@ -5880,7 +5880,6 @@ int t4_set_trace_filter(struct adapter *adap, const struct trace_params *tp,
 {
        int i, ofst = idx * 4;
        u32 data_reg, mask_reg, cfg;
-       u32 multitrc = TRCMULTIFILTER_F;
 
        if (!enable) {
                t4_write_reg(adap, MPS_TRC_FILTER_MATCH_CTL_A_A + ofst, 0);
@@ -5900,7 +5899,6 @@ int t4_set_trace_filter(struct adapter *adap, const struct trace_params *tp,
                 * maximum packet capture size of 9600 bytes is recommended.
                 * Also in this mode, only trace0 can be enabled and running.
                 */
-               multitrc = 0;
                if (tp->snap_len > 9600 || idx)
                        return -EINVAL;
        }
@@ -8606,7 +8604,7 @@ int t4_get_link_params(struct port_info *pi, unsigned int *link_okp,
 {
        unsigned int fw_caps = pi->adapter->params.fw_caps_support;
        struct fw_port_cmd port_cmd;
-       unsigned int action, link_ok, speed, mtu;
+       unsigned int action, link_ok, mtu;
        fw_port_cap32_t linkattr;
        int ret;
 
@@ -8640,7 +8638,6 @@ int t4_get_link_params(struct port_info *pi, unsigned int *link_okp,
                mtu = FW_PORT_CMD_MTU32_G(
                        be32_to_cpu(port_cmd.u.info32.auxlinfo32_mtu32));
        }
-       speed = fwcap_to_speed(linkattr);
 
        *link_okp = link_ok;
        *speedp = fwcap_to_speed(linkattr);