phy: hisilicon: Add of_node_put() in phy-hisi-inno-usb2

Fix following coccicheck warning:
./drivers/phy/hisilicon/phy-hisi-inno-usb2.c:138:1-23: WARNING: Function
for_each_child_of_node should have of_node_put() before break

Early exits from for_each_child_of_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Link: https://lore.kernel.org/r/20211015080154.16016-1-wanjiabing@vivo.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>

diff --git a/drivers/phy/hisilicon/phy-hisi-inno-usb2.c b/drivers/phy/hisilicon/phy-hisi-inno-usb2.c
index 34a6a9a..b133ae0 100644 (file)
--- a/drivers/phy/hisilicon/phy-hisi-inno-usb2.c
+++ b/drivers/phy/hisilicon/phy-hisi-inno-usb2.c
@@ -140,14 +140,19 @@ static int hisi_inno_phy_probe(struct platform_device *pdev)
                struct phy *phy;
 
                rst = of_reset_control_get_exclusive(child, NULL);
-               if (IS_ERR(rst))
+               if (IS_ERR(rst)) {
+                       of_node_put(child);
                        return PTR_ERR(rst);
+               }
+
                priv->ports[i].utmi_rst = rst;
                priv->ports[i].priv = priv;
 
                phy = devm_phy_create(dev, child, &hisi_inno_phy_ops);
-               if (IS_ERR(phy))
+               if (IS_ERR(phy)) {
+                       of_node_put(child);
                        return PTR_ERR(phy);
+               }
 
                phy_set_bus_width(phy, 8);
                phy_set_drvdata(phy, &priv->ports[i]);
@@ -155,6 +160,7 @@ static int hisi_inno_phy_probe(struct platform_device *pdev)
 
                if (i > INNO_PHY_PORT_NUM) {
                        dev_warn(dev, "Support %d ports in maximum\n", i);
+                       of_node_put(child);
                        break;
                }
        }