OSDN Git Service

greybus: connection: fix potential null-deref in hd_cport_enable
authorJohan Hovold <johan@hovoldconsulting.com>
Tue, 3 Nov 2015 11:11:29 +0000 (12:11 +0100)
committerGreg Kroah-Hartman <gregkh@google.com>
Thu, 5 Nov 2015 04:20:23 +0000 (20:20 -0800)
Use parent of host device for error messages as the connections bundle
may be NULL.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
drivers/staging/greybus/connection.c

index c70518e..e16ed4e 100644 (file)
@@ -196,7 +196,7 @@ static int gb_connection_hd_cport_enable(struct gb_connection *connection)
 
        ret = hd->driver->cport_enable(hd, connection->hd_cport_id);
        if (ret) {
-               dev_err(&connection->bundle->dev,
+               dev_err(hd->parent,
                        "failed to enable host cport: %d\n", ret);
                return ret;
        }