OSDN Git Service

misc: hpilo: avoid a useless memset
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 18 Jul 2020 07:02:46 +0000 (09:02 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 23 Jul 2020 10:56:49 +0000 (12:56 +0200)
Avoid a memset after a call to 'dma_alloc_coherent()'.
This is useless since
commit 518a2f1925c3 ("dma-mapping: zero memory returned from dma_alloc_*")

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/20200718070246.338016-1-christophe.jaillet@wanadoo.fr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/hpilo.c

index c9539c8..fea3ae9 100644 (file)
@@ -281,8 +281,6 @@ static int ilo_ccb_setup(struct ilo_hwinfo *hw, struct ccb_data *data, int slot)
        dma_va = (char *)data->dma_va;
        dma_pa = data->dma_pa;
 
-       memset(dma_va, 0, data->dma_size);
-
        dma_va = (char *)roundup((unsigned long)dma_va, ILO_START_ALIGN);
        dma_pa = roundup(dma_pa, ILO_START_ALIGN);