mt76: testmode: remove undefined behaviour in mt76_testmode_alloc_skb

Get rid of an undefined behaviour in mt76_testmode_alloc_skb routine
allocating skb frames

Fixes: 2601dda8faa76 ("mt76: testmode: add support to send larger packet")
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Felix Fietkau <nbd@nbd.name>

diff --git a/drivers/net/wireless/mediatek/mt76/testmode.c b/drivers/net/wireless/mediatek/mt76/testmode.c
index c516469..c6a85a0 100644 (file)
--- a/drivers/net/wireless/mediatek/mt76/testmode.c
+++ b/drivers/net/wireless/mediatek/mt76/testmode.c
@@ -159,12 +159,8 @@ int mt76_testmode_alloc_skb(struct mt76_phy *phy, u32 len)
                head->len += frag->len;
                head->data_len += frag->len;
 
-               if (*frag_tail) {
-                       (*frag_tail)->next = frag;
-                       frag_tail = &frag;
-               } else {
-                       *frag_tail = frag;
-               }
+               *frag_tail = frag;
+               frag_tail = &(*frag_tail)->next;
        }
 
        mt76_testmode_free_skb(phy);