OSDN Git Service

drm/i915: Add missing 'else' to intel_digital_port_connected()
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 11 Feb 2016 14:44:28 +0000 (16:44 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 15 Feb 2016 17:10:41 +0000 (19:10 +0200)
intel_digital_port_connected() lacks one 'else'. There's no
actual harm in not having it since each branch has an unconditional
return, so it can't accidentally end up in taking two branches instead
of just the one. But let's be consistent and add the 'else' anyway.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1455201868-31527-1-git-send-email-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/intel_dp.c

index afb9399..a48c429 100644 (file)
@@ -4561,7 +4561,7 @@ bool intel_digital_port_connected(struct drm_i915_private *dev_priv,
 {
        if (HAS_PCH_IBX(dev_priv))
                return ibx_digital_port_connected(dev_priv, port);
-       if (HAS_PCH_SPLIT(dev_priv))
+       else if (HAS_PCH_SPLIT(dev_priv))
                return cpt_digital_port_connected(dev_priv, port);
        else if (IS_BROXTON(dev_priv))
                return bxt_digital_port_connected(dev_priv, port);