Cppcheck: Variable '...' is assigned in constructor body. Consider performing initial...

diff --git a/Src/DirActions.cpp b/Src/DirActions.cpp
index 98e25be..e614a5e 100644 (file)
--- a/Src/DirActions.cpp
+++ b/Src/DirActions.cpp
@@ -34,10 +34,10 @@ static void ThrowConfirmationNeededException(const CDiffContext& ctxt, const Str
                const String& src, const String& dest, bool destIsSide);
 
 ContentsChangedException::ContentsChangedException(const String& failpath)
+       : m_msg(string_format_string1(
+               _("Operation aborted!\n\nFolder contents at disks has changed, path\n%1\nwas not found.\n\nPlease refresh the compare."),
+               failpath))
 {
-       m_msg = string_format_string1(
-       _("Operation aborted!\n\nFolder contents at disks has changed, path\n%1\nwas not found.\n\nPlease refresh the compare."),
-       failpath);
 }
 
 /**

diff --git a/Src/SelectUnpackerDlg.cpp b/Src/SelectUnpackerDlg.cpp
index 69f8153..9056323 100644 (file)
--- a/Src/SelectUnpackerDlg.cpp
+++ b/Src/SelectUnpackerDlg.cpp
@@ -105,18 +105,14 @@ void CSelectUnpackerDlg::Initialize()
 
 
 CSelectUnpackerDlg::CSelectUnpackerDlg(const String& filename, CWnd* pParent /*=NULL*/)
-       : CTrDialog(CSelectUnpackerDlg::IDD, pParent)
+       : CTrDialog(CSelectUnpackerDlg::IDD, pParent), m_filteredFilenames(filename)
 {
-       m_filteredFilenames = filename;
        Initialize();
 }
 
 CSelectUnpackerDlg::CSelectUnpackerDlg(const String& filename1, const String& filename2, CWnd* pParent /*=NULL*/)
-       : CTrDialog(CSelectUnpackerDlg::IDD, pParent)
+       : CTrDialog(CSelectUnpackerDlg::IDD, pParent), m_filteredFilenames(filename1 + _T("|") + filename2)
 {
-       m_filteredFilenames = filename1;
-       m_filteredFilenames += _T("|");
-       m_filteredFilenames += filename2;
        Initialize();
 }