OSDN Git Service

can: mcba_usb: remove h from printk format specifier
authorTom Rix <trix@redhat.com>
Sun, 24 Jan 2021 15:09:16 +0000 (07:09 -0800)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Wed, 27 Jan 2021 09:01:46 +0000 (10:01 +0100)
This change fixes the checkpatch warning described in this commit commit
cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary
%h[xudi] and %hh[xudi]")

Standard integer promotion is already done and %hx and %hhx is useless so do
not encourage the use of %hh[xudi] or %h[xudi].

Link: https://lore.kernel.org/r/20210124150916.1920434-1-trix@redhat.com
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/usb/mcba_usb.c

index 4232a71..1f649d1 100644 (file)
@@ -466,7 +466,7 @@ static void mcba_usb_process_ka_usb(struct mcba_priv *priv,
                                    struct mcba_usb_msg_ka_usb *msg)
 {
        if (unlikely(priv->usb_ka_first_pass)) {
-               netdev_info(priv->netdev, "PIC USB version %hhu.%hhu\n",
+               netdev_info(priv->netdev, "PIC USB version %u.%u\n",
                            msg->soft_ver_major, msg->soft_ver_minor);
 
                priv->usb_ka_first_pass = false;
@@ -492,7 +492,7 @@ static void mcba_usb_process_ka_can(struct mcba_priv *priv,
                                    struct mcba_usb_msg_ka_can *msg)
 {
        if (unlikely(priv->can_ka_first_pass)) {
-               netdev_info(priv->netdev, "PIC CAN version %hhu.%hhu\n",
+               netdev_info(priv->netdev, "PIC CAN version %u.%u\n",
                            msg->soft_ver_major, msg->soft_ver_minor);
 
                priv->can_ka_first_pass = false;
@@ -554,7 +554,7 @@ static void mcba_usb_process_rx(struct mcba_priv *priv,
                break;
 
        default:
-               netdev_warn(priv->netdev, "Unsupported msg (0x%hhX)",
+               netdev_warn(priv->netdev, "Unsupported msg (0x%X)",
                            msg->cmd_id);
                break;
        }