OSDN Git Service

9p: darwin: Explicitly cast comparisons of mode_t with -1
authorKeno Fischer <keno@juliacomputing.com>
Fri, 29 Jun 2018 10:32:10 +0000 (12:32 +0200)
committerGreg Kurz <groug@kaod.org>
Fri, 29 Jun 2018 10:32:10 +0000 (12:32 +0200)
Comparisons of mode_t with -1 require an explicit cast, since mode_t
is unsigned on Darwin.

Signed-off-by: Keno Fischer <keno@juliacomputing.com>
Signed-off-by: Greg Kurz <groug@kaod.org>
hw/9pfs/9p-local.c

index 828e8d6..c30f4f2 100644 (file)
@@ -308,7 +308,7 @@ update_map_file:
     if (credp->fc_gid != -1) {
         gid = credp->fc_gid;
     }
-    if (credp->fc_mode != -1) {
+    if (credp->fc_mode != (mode_t)-1) {
         mode = credp->fc_mode;
     }
     if (credp->fc_rdev != -1) {
@@ -414,7 +414,7 @@ static int local_set_xattrat(int dirfd, const char *path, FsCred *credp)
             return err;
         }
     }
-    if (credp->fc_mode != -1) {
+    if (credp->fc_mode != (mode_t)-1) {
         uint32_t tmp_mode = cpu_to_le32(credp->fc_mode);
         err = fsetxattrat_nofollow(dirfd, path, "user.virtfs.mode", &tmp_mode,
                                    sizeof(mode_t), 0);