OSDN Git Service

firmware: arm_scmi: remove some unnecessary checks
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 19 May 2018 06:37:15 +0000 (09:37 +0300)
committerSudeep Holla <sudeep.holla@arm.com>
Mon, 9 Jul 2018 09:50:20 +0000 (10:50 +0100)
The "pi->dom_info" buffer is allocated in init() and it can't be NULL
here.  These tests are sort of weird as well because if "pi->dom_info"
was NULL but "domain" was non-zero then it would lead to an Oops.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
drivers/firmware/arm_scmi/perf.c

index 2a219b1..721e6c5 100644 (file)
@@ -363,8 +363,6 @@ static int scmi_dvfs_device_opps_add(const struct scmi_handle *handle,
                return domain;
 
        dom = pi->dom_info + domain;
-       if (!dom)
-               return -EIO;
 
        for (opp = dom->opp, idx = 0; idx < dom->opp_count; idx++, opp++) {
                freq = opp->perf * dom->mult_factor;
@@ -394,9 +392,6 @@ static int scmi_dvfs_transition_latency_get(const struct scmi_handle *handle,
                return domain;
 
        dom = pi->dom_info + domain;
-       if (!dom)
-               return -EIO;
-
        /* uS to nS */
        return dom->opp[dom->opp_count - 1].trans_latency_us * 1000;
 }