OSDN Git Service

platform/x86: int3472/discrete: Drop unnecessary obj->type == string check
authorHans de Goede <hdegoede@redhat.com>
Sat, 4 Feb 2023 11:02:23 +0000 (12:02 +0100)
committerHans de Goede <hdegoede@redhat.com>
Mon, 6 Feb 2023 13:46:02 +0000 (14:46 +0100)
acpi_evaluate_dsm_typed() already verifies the type is the requested type,
so this error check is a no-op, drop it.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20230204110223.54625-1-hdegoede@redhat.com
drivers/platform/x86/intel/int3472/discrete.c

index 96963e3..f064da7 100644 (file)
@@ -78,14 +78,6 @@ skl_int3472_get_sensor_module_config(struct int3472_discrete_device *int3472)
                return ERR_PTR(-ENODEV);
        }
 
-       if (obj->string.type != ACPI_TYPE_STRING) {
-               dev_err(int3472->dev,
-                       "Sensor _DSM returned a non-string value\n");
-
-               ACPI_FREE(obj);
-               return ERR_PTR(-EINVAL);
-       }
-
        for (i = 0; i < ARRAY_SIZE(int3472_sensor_configs); i++) {
                if (!strcmp(int3472_sensor_configs[i].sensor_module_name,
                            obj->string.pointer))