OSDN Git Service

mmc: sunxi-mmc: Handle return value of platform_get_irq
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Sun, 19 Nov 2017 04:52:47 +0000 (10:22 +0530)
committerUlf Hansson <ulf.hansson@linaro.org>
Fri, 15 Dec 2017 08:13:16 +0000 (09:13 +0100)
platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sunxi-mmc.c

index 8fef5c1..bad612d 100644 (file)
@@ -1255,6 +1255,11 @@ static int sunxi_mmc_resource_request(struct sunxi_mmc_host *host,
                goto error_assert_reset;
 
        host->irq = platform_get_irq(pdev, 0);
+       if (host->irq <= 0) {
+               ret = -EINVAL;
+               goto error_assert_reset;
+       }
+
        return devm_request_threaded_irq(&pdev->dev, host->irq, sunxi_mmc_irq,
                        sunxi_mmc_handle_manual_stop, 0, "sunxi-mmc", host);