slimbus: fix inconsistent mutex_lock

drivers/slimbus/slimbus.c:1331 slim_config_mgrports() warn: inconsistent
returns 'mutex:&ctrl->sched.m_reconf'

Change-Id: I023f69cc3496e9b98d9881c447fc1bf9053de97f
Signed-off-by: David Lin <dtwlin@google.com>

diff --git a/drivers/slimbus/slimbus.c b/drivers/slimbus/slimbus.c
index 72ac5b8..5b1e7f2 100644 (file)
--- a/drivers/slimbus/slimbus.c
+++ b/drivers/slimbus/slimbus.c
@@ -1323,8 +1323,10 @@ int slim_config_mgrports(struct slim_device *sb, u32 *ph, int nports,
        for (i = 0; i < nports; i++) {
                u8 pn = SLIM_HDL_TO_PORT(ph[i]);
 
-               if (ctrl->ports[pn].state == SLIM_P_CFG)
+               if (ctrl->ports[pn].state == SLIM_P_CFG) {
+                       mutex_unlock(&ctrl->sched.m_reconf);
                        return -EISCONN;
+               }
                ctrl->ports[pn].cfg = *cfg;
        }
        mutex_unlock(&ctrl->sched.m_reconf);