OSDN Git Service

powerpc/numa: Remove late request for home node associativity
authorSrikar Dronamraju <srikar@linux.vnet.ibm.com>
Wed, 29 Jan 2020 13:53:01 +0000 (19:23 +0530)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 4 Mar 2020 11:44:31 +0000 (22:44 +1100)
With commit ("powerpc/numa: Early request for home node associativity"),
commit 2ea626306810 ("powerpc/topology: Get topology for shared
processors at boot") which was requesting home node associativity
becomes redundant.

Hence remove the late request for home node associativity.

Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Reported-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
Reviewed-by: Nathan Lynch <nathanl@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20200129135301.24739-6-srikar@linux.vnet.ibm.com
arch/powerpc/include/asm/topology.h
arch/powerpc/kernel/smp.c
arch/powerpc/mm/numa.c

index e2e1ccd..2db7ba7 100644 (file)
@@ -98,7 +98,6 @@ extern int stop_topology_update(void);
 extern int prrn_is_enabled(void);
 extern int find_and_online_cpu_nid(int cpu);
 extern int timed_topology_update(int nsecs);
-extern void __init shared_proc_topology_init(void);
 #else
 static inline int start_topology_update(void)
 {
@@ -121,9 +120,6 @@ static inline int timed_topology_update(int nsecs)
        return 0;
 }
 
-#ifdef CONFIG_SMP
-static inline void shared_proc_topology_init(void) {}
-#endif
 #endif /* CONFIG_NUMA && CONFIG_PPC_SPLPAR */
 
 #include <asm-generic/topology.h>
index f68cde8..37c12e3 100644 (file)
@@ -1383,11 +1383,6 @@ void __init smp_cpus_done(unsigned int max_cpus)
        if (smp_ops && smp_ops->bringup_done)
                smp_ops->bringup_done();
 
-       /*
-        * On a shared LPAR, associativity needs to be requested.
-        * Hence, get numa topology before dumping cpu topology
-        */
-       shared_proc_topology_init();
        dump_numa_cpu_topology();
 
 #ifdef CONFIG_SCHED_SMT
index 5a8abf0..9fcf2d1 100644 (file)
@@ -1632,15 +1632,6 @@ int prrn_is_enabled(void)
        return prrn_enabled;
 }
 
-void __init shared_proc_topology_init(void)
-{
-       if (lppaca_shared_proc(get_lppaca())) {
-               bitmap_fill(cpumask_bits(&cpu_associativity_changes_mask),
-                           nr_cpumask_bits);
-               numa_update_cpu_topology(false);
-       }
-}
-
 static int topology_read(struct seq_file *file, void *v)
 {
        if (vphn_enabled || prrn_enabled)