OSDN Git Service

mmc: renesas_sdhi: remove always false condition
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Fri, 24 Nov 2017 16:24:46 +0000 (01:24 +0900)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 19 Dec 2017 07:50:04 +0000 (08:50 +0100)
renesas_sdhi_probe() always sets host->dma as follows:

        host->dma               = dma_priv;

!host->dma is always false.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/renesas_sdhi_sys_dmac.c

index 9ab1043..e210644 100644 (file)
@@ -360,8 +360,8 @@ static void renesas_sdhi_sys_dmac_request_dma(struct tmio_mmc_host *host,
                                              struct tmio_mmc_data *pdata)
 {
        /* We can only either use DMA for both Tx and Rx or not use it at all */
-       if (!host->dma || (!host->pdev->dev.of_node &&
-                          (!pdata->chan_priv_tx || !pdata->chan_priv_rx)))
+       if (!host->pdev->dev.of_node &&
+           (!pdata->chan_priv_tx || !pdata->chan_priv_rx))
                return;
 
        if (!host->chan_tx && !host->chan_rx) {