OSDN Git Service

media: exynos4-is: Use PTR_ERR_OR_ZERO()
authorVasyl Gomonovych <gomonovych@gmail.com>
Wed, 29 Nov 2017 16:20:16 +0000 (11:20 -0500)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Fri, 8 Dec 2017 16:29:04 +0000 (11:29 -0500)
Fix ptr_ret.cocci warnings:
drivers/media/platform/exynos4-is/fimc-lite.c:1465:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/exynos4-is/fimc-lite.c

index 4a3c994..5db572a 100644 (file)
@@ -1462,10 +1462,7 @@ static void fimc_lite_clk_put(struct fimc_lite *fimc)
 static int fimc_lite_clk_get(struct fimc_lite *fimc)
 {
        fimc->clock = clk_get(&fimc->pdev->dev, FLITE_CLK_NAME);
-       if (IS_ERR(fimc->clock))
-               return PTR_ERR(fimc->clock);
-
-       return 0;
+       return PTR_ERR_OR_ZERO(fimc->clock);
 }
 
 static const struct of_device_id flite_of_match[];