OSDN Git Service

qla2xxx: Incorrect linked list semantic in qlafx00_get_fcport().
authorJoe Carnuccio <joe.carnuccio@qlogic.com>
Thu, 25 Sep 2014 09:16:44 +0000 (05:16 -0400)
committerChristoph Hellwig <hch@lst.de>
Thu, 25 Sep 2014 12:25:02 +0000 (14:25 +0200)
Signed-off-by: Joe Carnuccio <joe.carnuccio@qlogic.com>
Signed-off-by: Saurav Kashyap <saurav.kashyap@qlogic.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/scsi/qla2xxx/qla_mr.c

index 8ecf6de..620e60a 100644 (file)
@@ -1675,17 +1675,16 @@ qlafx00_get_fcport(struct scsi_qla_host *vha, int tgt_id)
        fc_port_t       *fcport;
 
        /* Check for matching device in remote port list. */
-       fcport = NULL;
        list_for_each_entry(fcport, &vha->vp_fcports, list) {
                if (fcport->tgt_id == tgt_id) {
                        ql_dbg(ql_dbg_async, vha, 0x5072,
                            "Matching fcport(%p) found with TGT-ID: 0x%x "
                            "and Remote TGT_ID: 0x%x\n",
                            fcport, fcport->tgt_id, tgt_id);
-                       break;
+                       return fcport;
                }
        }
-       return fcport;
+       return NULL;
 }
 
 static void