OSDN Git Service

drm/amd/display: cleanup the code a bit
authorBernard Zhao <bernard@vivo.com>
Tue, 16 Nov 2021 01:34:35 +0000 (17:34 -0800)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 22 Nov 2021 19:45:03 +0000 (14:45 -0500)
In function dc_sink_destruct, kfree will check pointer, no need
to check again.
This change is to cleanup the code a bit.

Acked-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Bernard Zhao <bernard@vivo.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/core/dc_sink.c

index a249a0e..4b5e4d8 100644 (file)
  * Private functions
  ******************************************************************************/
 
-static void dc_sink_destruct(struct dc_sink *sink)
-{
-       if (sink->dc_container_id) {
-               kfree(sink->dc_container_id);
-               sink->dc_container_id = NULL;
-       }
-}
-
 static bool dc_sink_construct(struct dc_sink *sink, const struct dc_sink_init_data *init_params)
 {
 
@@ -75,7 +67,7 @@ void dc_sink_retain(struct dc_sink *sink)
 static void dc_sink_free(struct kref *kref)
 {
        struct dc_sink *sink = container_of(kref, struct dc_sink, refcount);
-       dc_sink_destruct(sink);
+       kfree(sink->dc_container_id);
        kfree(sink);
 }