OSDN Git Service

arm64: dts: qcom: apq8016-sbc: Clarify firmware-names
authorStephan Gerhold <stephan@gerhold.net>
Wed, 22 Sep 2021 19:58:53 +0000 (21:58 +0200)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Fri, 15 Oct 2021 00:54:58 +0000 (19:54 -0500)
Commit 0f6b380d580c ("arm64: dts: qcom: apq8016-sbc: Update modem and WiFi
firmware path") added "firmware-name"s to the APQ8016 SBC (DB410c) device
tree to separate the (test key)-signed firmware from other devices.

However, the added names are a bit confusing. The "modem" firmware used by
DB410c is actually a simplified version for APQ8016 that lacks most of the
modem functionality (phone calls, SMS etc) that is available on MSM8916.
Placing it in "qcom/msm8916/modem.mbn" suggests that it supports all
functionality for MSM and not just the reduced functionality for APQ.

Request the firmware from "qcom/apq8016/modem.mbn" instead to clarify this.
Do the same for "wcnss.mbn" for consistency (although the WCNSS firmware
works just fine on MSM8916).

Finally, add a "_sbc" suffix to the WCNSS_qcom_wlan_nv.bin firmware file.
It seems like the nv.bin firmware is somewhat board specific and can
therefore vary a bit from device to device. This makes it more clear
which board it is intended to be used for.

Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20210922195853.95574-1-stephan@gerhold.net
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi

index 351c68d..0e4a1f0 100644 (file)
 &mpss {
        status = "okay";
 
-       firmware-name = "qcom/msm8916/mba.mbn", "qcom/msm8916/modem.mbn";
+       firmware-name = "qcom/apq8016/mba.mbn", "qcom/apq8016/modem.mbn";
 };
 
 &pm8916_resin {
 &pronto {
        status = "okay";
 
-       firmware-name = "qcom/msm8916/wcnss.mbn";
+       firmware-name = "qcom/apq8016/wcnss.mbn";
 };
 
 &sdhc_1 {
 };
 
 &wcnss_ctrl {
-       firmware-name = "qcom/msm8916/WCNSS_qcom_wlan_nv.bin";
+       firmware-name = "qcom/apq8016/WCNSS_qcom_wlan_nv_sbc.bin";
 };
 
 /* Enable CoreSight */