OSDN Git Service

scsi: qla2xxx: Remove dead code
authorBart Van Assche <bvanassche@acm.org>
Fri, 9 Aug 2019 03:01:46 +0000 (20:01 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 13 Aug 2019 01:34:06 +0000 (21:34 -0400)
Since sess == NULL before 'goto out_term2' is executed, the code under 'if
(sess)' cannot be reached. Hence remove that code. This was detected by
Coverity.

Cc: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Tested-by: Himanshu Madhani <hmadhani@marvell.com>
Reviewed-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_target.c

index 9cd5e2f..ba53329 100644 (file)
@@ -6249,9 +6249,6 @@ static void qlt_abort_work(struct qla_tgt *tgt,
 out_term2:
        spin_unlock_irqrestore(&ha->tgt.sess_lock, flags2);
 
-       if (sess)
-               ha->tgt.tgt_ops->put_sess(sess);
-
 out_term:
        spin_lock_irqsave(&ha->hardware_lock, flags);
        qlt_24xx_send_abts_resp(ha->base_qpair, &prm->abts,