OSDN Git Service

phy: cpcap-usb: Fix missing return statement
authorTony Lindgren <tony@atomide.com>
Mon, 12 Jun 2017 08:12:23 +0000 (01:12 -0700)
committerKishon Vijay Abraham I <kishon@ti.com>
Fri, 16 Jun 2017 06:10:21 +0000 (11:40 +0530)
Commit 8ae904e3c236 ("phy: cpcap-usb: Add CPCAP PMIC USB support")
is missing return statement as noted by Colin Ian King
<colin.king@canonical.com>. If the optional pins are not configured,
we just want to return early and not attempt to configure the pins.

Fixes: 8ae904e3c236 ("phy: cpcap-usb: Add CPCAP PMIC USB support")
Reported-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
drivers/phy/motorola/phy-cpcap-usb.c

index 082a48b..9b63efa 100644 (file)
@@ -468,6 +468,8 @@ static int cpcap_usb_init_optional_pins(struct cpcap_phy_ddata *ddata)
                dev_info(ddata->dev, "default pins not configured: %ld\n",
                         PTR_ERR(ddata->pins));
                ddata->pins = NULL;
+
+               return 0;
        }
 
        ddata->pins_ulpi = pinctrl_lookup_state(ddata->pins, "ulpi");