OSDN Git Service

s390x/pci: fix s390_pci_sclp_deconfigure
authorYi Min Zhao <zyimin@linux.vnet.ibm.com>
Thu, 28 Apr 2016 05:22:51 +0000 (13:22 +0800)
committerCornelia Huck <cornelia.huck@de.ibm.com>
Tue, 17 May 2016 13:50:29 +0000 (15:50 +0200)
When deconfiguring a s390 pci device, we should deconfigure the
corresponding IOMMU memory region and the IRQs for the device.

Signed-off-by: Yi Min Zhao <zyimin@linux.vnet.ibm.com>
Reviewed-by: Pierre Morel <pmorel@linux.vnet.ibm.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
hw/s390x/s390-pci-bus.c

index 5d54c73..b2cd31c 100644 (file)
@@ -15,6 +15,7 @@
 #include "qemu-common.h"
 #include "cpu.h"
 #include "s390-pci-bus.h"
+#include "s390-pci-inst.h"
 #include <hw/pci/pci_bus.h>
 #include <hw/pci/msi.h>
 #include <qemu/error-report.h>
@@ -137,6 +138,12 @@ void s390_pci_sclp_deconfigure(SCCB *sccb)
         if (!pbdev->configured) {
             rc = SCLP_RC_NO_ACTION_REQUIRED;
         } else {
+            if (pbdev->summary_ind) {
+                pci_dereg_irqs(pbdev);
+            }
+            if (pbdev->iommu_enabled) {
+                pci_dereg_ioat(pbdev);
+            }
             pbdev->configured = false;
             rc = SCLP_RC_NORMAL_COMPLETION;
         }