Extract method to check shouldShowSearchBox for StartMenuController

Test: ./gradlew test

Signed-off-by: utzcoz <utzcoz@outlook.com>

diff --git a/app/src/main/java/com/farmerbb/taskbar/ui/StartMenuController.java b/app/src/main/java/com/farmerbb/taskbar/ui/StartMenuController.java
index e019984..524318d 100644 (file)
--- a/app/src/main/java/com/farmerbb/taskbar/ui/StartMenuController.java
+++ b/app/src/main/java/com/farmerbb/taskbar/ui/StartMenuController.java
@@ -36,6 +36,8 @@ import android.os.Handler;
 import android.os.UserHandle;
 import android.os.UserManager;
 import android.provider.Settings;
+
+import androidx.annotation.VisibleForTesting;
 import androidx.appcompat.widget.SearchView;
 import android.util.Patterns;
 import android.view.Gravity;
@@ -176,17 +178,7 @@ public class StartMenuController extends UIController {
         IconCache.getInstance(context).clearCache();
 
         final SharedPreferences pref = U.getSharedPreferences(context);
-        switch(pref.getString(PREF_SHOW_SEARCH_BAR, "always")) {
-            case "always":
-                shouldShowSearchBox = true;
-                break;
-            case "keyboard":
-                shouldShowSearchBox = hasHardwareKeyboard;
-                break;
-            case "never":
-                shouldShowSearchBox = false;
-                break;
-        }
+        shouldShowSearchBox = shouldShowSearchBox(pref, hasHardwareKeyboard);
 
         // Initialize layout params
         WindowManager windowManager = (WindowManager) context.getSystemService(Context.WINDOW_SERVICE);
@@ -416,6 +408,23 @@ public class StartMenuController extends UIController {
         host.addView(layout, params);
     }
 
+    @VisibleForTesting
+    boolean shouldShowSearchBox(SharedPreferences pref, boolean hasHardwareKeyboard) {
+        boolean shouldShowSearchBox;
+        switch(pref.getString(PREF_SHOW_SEARCH_BAR, "always")) {
+            case "always":
+                shouldShowSearchBox = true;
+                break;
+            case "keyboard":
+                shouldShowSearchBox = hasHardwareKeyboard;
+                break;
+            default:
+                shouldShowSearchBox = false;
+                break;
+        }
+        return shouldShowSearchBox;
+    }
+
     private void refreshApps(boolean firstDraw) {
         refreshApps(null, firstDraw);
     }

diff --git a/app/src/test/java/com/farmerbb/taskbar/ui/StartMenuControllerTest.java b/app/src/test/java/com/farmerbb/taskbar/ui/StartMenuControllerTest.java
new file mode 100644 (file)
index 0000000..10c5662
--- /dev/null
+++ b/app/src/test/java/com/farmerbb/taskbar/ui/StartMenuControllerTest.java
@@ -0,0 +1,73 @@
+package com.farmerbb.taskbar.ui;
+
+import android.content.Context;
+import android.content.SharedPreferences;
+
+import androidx.test.core.app.ApplicationProvider;
+
+import com.farmerbb.taskbar.util.TaskbarPosition;
+import com.farmerbb.taskbar.util.U;
+
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.powermock.core.classloader.annotations.PowerMockIgnore;
+import org.powermock.core.classloader.annotations.PrepareForTest;
+import org.powermock.modules.junit4.rule.PowerMockRule;
+import org.robolectric.RobolectricTestRunner;
+
+import static com.farmerbb.taskbar.util.Constants.PREF_SHOW_SEARCH_BAR;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
+@RunWith(RobolectricTestRunner.class)
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*",
+        "android.*", "androidx.*", "com.farmerbb.taskbar.shadow.*"})
+@PrepareForTest(value = {U.class, TaskbarPosition.class})
+public class StartMenuControllerTest {
+    private static final String UNSUPPORTED = "unsupported";
+
+    @Rule
+    public PowerMockRule rule = new PowerMockRule();
+
+    private StartMenuController uiController;
+    private Context context;
+    private SharedPreferences prefs;
+    private UIHost host = new MockUIHost();
+
+    @Before
+    public void setUp() {
+        context = ApplicationProvider.getApplicationContext();
+        uiController = new StartMenuController(context);
+        prefs = U.getSharedPreferences(context);
+
+        uiController.onCreateHost(host);
+    }
+
+    @After
+    public void tearDown() {
+        prefs.edit().remove(PREF_SHOW_SEARCH_BAR).apply();
+        uiController.onDestroyHost(host);
+    }
+
+    @Test
+    public void testShouldShowSearchBox() {
+        prefs.edit().remove(PREF_SHOW_SEARCH_BAR).apply();
+        assertTrue(uiController.shouldShowSearchBox(prefs, false));
+
+        prefs.edit().putString(PREF_SHOW_SEARCH_BAR, "always").apply();
+        assertTrue(uiController.shouldShowSearchBox(prefs, false));
+
+        prefs.edit().putString(PREF_SHOW_SEARCH_BAR, "keyboard").apply();
+        assertFalse(uiController.shouldShowSearchBox(prefs, false));
+        assertTrue(uiController.shouldShowSearchBox(prefs, true));
+
+        prefs.edit().putString(PREF_SHOW_SEARCH_BAR, "never").apply();
+        assertFalse(uiController.shouldShowSearchBox(prefs, true));
+
+        prefs.edit().putString(PREF_SHOW_SEARCH_BAR, UNSUPPORTED).apply();
+        assertFalse(uiController.shouldShowSearchBox(prefs, true));
+    }
+}