OSDN Git Service

crypto: atmel-sha - Drop if with an always false condition
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tue, 5 Jul 2022 20:51:39 +0000 (22:51 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 15 Jul 2022 08:43:20 +0000 (16:43 +0800)
The remove callback is only called after probe completed successfully.
In this case platform_set_drvdata() was called with a non-NULL argument
and so sha_dd is never NULL.

This is a preparation for making platform remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/atmel-sha.c

index d162811..e054e0a 100644 (file)
@@ -2669,8 +2669,7 @@ static int atmel_sha_remove(struct platform_device *pdev)
        struct atmel_sha_dev *sha_dd;
 
        sha_dd = platform_get_drvdata(pdev);
-       if (!sha_dd)
-               return -ENODEV;
+
        spin_lock(&atmel_sha.lock);
        list_del(&sha_dd->list);
        spin_unlock(&atmel_sha.lock);