OSDN Git Service

Fix inverted error code.
authorJanis Danisevskis <jdanis@google.com>
Wed, 5 Dec 2018 00:52:58 +0000 (16:52 -0800)
committerJanis Danisevskis <jdanis@google.com>
Wed, 5 Dec 2018 21:03:20 +0000 (21:03 +0000)
During the Multithreaded keystore refactor the error code returned by
getKeyCharacteristics was mistakenly inverted.

Test: yes please!
Bug: 120182820
Bug: 111443219
Change-Id: I5f5c07f30e0ee264ce75a5ffd2986186b9d66ce3

wifi/keystore/1.0/default/keystore.cpp

index c1594e8..fef8400 100644 (file)
@@ -165,7 +165,7 @@ Return<void> Keystore::sign(const hidl_string& keyId, const hidl_vec<uint8_t>& d
 
     auto [km_response, characteristics] = kc_future.get();
 
-    if (KSReturn(km_response.response_code()).isOk()) {
+    if (!KSReturn(km_response.response_code()).isOk()) {
         LOG(ERROR) << AT << "getKeyCharacteristics failed: " << km_response.response_code();
         _hidl_cb(KeystoreStatusCode::ERROR_UNKNOWN, {});
         return Void();