OSDN Git Service

l2tp: make l2tp_xmit_core() return void
authorGuillaume Nault <g.nault@alphalink.fr>
Mon, 25 Jun 2018 14:07:25 +0000 (16:07 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 26 Jun 2018 13:55:51 +0000 (22:55 +0900)
It always returns 0, and nobody reads the return value anyway.

Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/l2tp/l2tp_core.c

index 88c3001..1ea285b 100644 (file)
@@ -1007,8 +1007,8 @@ static int l2tp_build_l2tpv3_header(struct l2tp_session *session, void *buf)
        return bufp - optr;
 }
 
-static int l2tp_xmit_core(struct l2tp_session *session, struct sk_buff *skb,
-                         struct flowi *fl, size_t data_len)
+static void l2tp_xmit_core(struct l2tp_session *session, struct sk_buff *skb,
+                          struct flowi *fl, size_t data_len)
 {
        struct l2tp_tunnel *tunnel = session->tunnel;
        unsigned int len = skb->len;
@@ -1050,8 +1050,6 @@ static int l2tp_xmit_core(struct l2tp_session *session, struct sk_buff *skb,
                atomic_long_inc(&tunnel->stats.tx_errors);
                atomic_long_inc(&session->stats.tx_errors);
        }
-
-       return 0;
 }
 
 /* If caller requires the skb to have a ppp header, the header must be