OSDN Git Service

drm/i810: make i810_flush_queue() return void
authorJason Yan <yanaijie@huawei.com>
Thu, 10 Sep 2020 14:06:10 +0000 (22:06 +0800)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 11 Sep 2020 08:54:17 +0000 (10:54 +0200)
This function always return '0' and no callers use the return value. So
make it a void function.

This eliminates the following coccicheck warning:

drivers/gpu/drm/i810/i810_dma.c:860:8-11: Unneeded variable: "ret".
Return "0" on line 885

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20200910140610.1191578-1-yanaijie@huawei.com
drivers/gpu/drm/i810/i810_dma.c

index 303c2d4..8825086 100644 (file)
@@ -853,11 +853,11 @@ static void i810_dma_quiescent(struct drm_device *dev)
        i810_wait_ring(dev, dev_priv->ring.Size - 8);
 }
 
-static int i810_flush_queue(struct drm_device *dev)
+static void i810_flush_queue(struct drm_device *dev)
 {
        drm_i810_private_t *dev_priv = dev->dev_private;
        struct drm_device_dma *dma = dev->dma;
-       int i, ret = 0;
+       int i;
        RING_LOCALS;
 
        i810_kernel_lost_context(dev);
@@ -882,7 +882,7 @@ static int i810_flush_queue(struct drm_device *dev)
                        DRM_DEBUG("still on client\n");
        }
 
-       return ret;
+       return;
 }
 
 /* Must be called with the lock held */