OSDN Git Service

drm/bridge: anx7625: Return -EPROBE_DEFER if the dsi host was not found
authorowen <qwt9588@gmail.com>
Mon, 17 Jan 2022 10:09:49 +0000 (18:09 +0800)
committerRobert Foss <robert.foss@linaro.org>
Mon, 17 Jan 2022 15:39:30 +0000 (16:39 +0100)
It will connect to the mipi dsi host and find the corresponding
mipi dsi host node, but the node registered by the mipi dsi host
has not been loaded yet. of_find_mipi_dsi_host_by_node() returns -EINVAL
which causes the calling driver to fail.

If the anx7625 driver is loaded afterwards the driver requesting
the mipi dsi host will not notice this.

Better approach is to return -EPROBE_DEFER in such case.
Then when the anx7625 driver appears the driver requesting
the mipi dsi host will be probed again.

Signed-off-by: owen <qwt9588@gmail.com>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220117100949.9542-1-qwt9588@gamil.com
Reviewed-by: Robert Foss <robert.foss@linaro.org>
drivers/gpu/drm/bridge/analogix/anx7625.c

index 0528c3c..76662fc 100644 (file)
@@ -1917,7 +1917,7 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx)
        host = of_find_mipi_dsi_host_by_node(ctx->pdata.mipi_host_node);
        if (!host) {
                DRM_DEV_ERROR(dev, "fail to find dsi host.\n");
-               return -EINVAL;
+               return -EPROBE_DEFER;
        }
 
        dsi = devm_mipi_dsi_device_register_full(dev, host, &info);