OSDN Git Service

regulator: core: Release coupled_rdevs on regulator_init_coupling() error
authorDmitry Osipenko <digetx@gmail.com>
Fri, 25 Oct 2019 00:22:39 +0000 (03:22 +0300)
committerMark Brown <broonie@kernel.org>
Mon, 28 Oct 2019 13:14:45 +0000 (13:14 +0000)
This patch fixes memory leak which should happen if regulator's coupling
fails to initialize.

Fixes: d8ca7d184b33 ("regulator: core: Introduce API for regulators coupling customization")
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Link: https://lore.kernel.org/r/20191025002240.25288-1-digetx@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/core.c

index a46be22..51ce280 100644 (file)
@@ -5198,6 +5198,7 @@ unset_supplies:
        regulator_remove_coupling(rdev);
        mutex_unlock(&regulator_list_mutex);
 wash:
+       kfree(rdev->coupling_desc.coupled_rdevs);
        kfree(rdev->constraints);
        mutex_lock(&regulator_list_mutex);
        regulator_ena_gpio_free(rdev);