OSDN Git Service

staging: comedi: usbdux: remove impossible 'if (!devpriv)' check
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Fri, 14 Aug 2015 22:23:30 +0000 (15:23 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 13 Sep 2015 01:24:17 +0000 (18:24 -0700)
The comedi core can only call this subdevice function is the private
data was successfully allocated during the (*auto_attach). Remove
the unnecessary check.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/usbdux.c

index d576af7..eea41e8 100644 (file)
@@ -877,13 +877,9 @@ ao_trig_exit:
 static int usbdux_ao_cmdtest(struct comedi_device *dev,
                             struct comedi_subdevice *s, struct comedi_cmd *cmd)
 {
-       struct usbdux_private *devpriv = dev->private;
        int err = 0;
        unsigned int flags;
 
-       if (!devpriv)
-               return -EFAULT;
-
        /* Step 1 : check if triggers are trivially valid */
 
        err |= comedi_check_trigger_src(&cmd->start_src, TRIG_NOW | TRIG_INT);