OSDN Git Service

drm/bridge: tc358767: remove check for video mode in link enable
authorTomi Valkeinen <tomi.valkeinen@ti.com>
Tue, 28 May 2019 08:27:40 +0000 (11:27 +0300)
committerAndrzej Hajda <a.hajda@samsung.com>
Fri, 31 May 2019 13:41:26 +0000 (15:41 +0200)
tc_main_link_enable() checks if videomode has been set, and fails if
there's no videomode. As tc_main_link_enable() no longer depends on the
videomode, we can drop the check.

Also, while tc_stream_enable() does depend on the videomode, we can
expect that a mode has been set before drm_bridge_funcs.enable is
called, so we don't need the check there either.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190528082747.3631-18-tomi.valkeinen@ti.com
drivers/gpu/drm/bridge/tc358767.c

index 10a9b46..604e54b 100644 (file)
@@ -773,10 +773,6 @@ static int tc_main_link_enable(struct tc_data *tc)
        int ret;
        u8 tmp[8];
 
-       /* display mode should be set at this point */
-       if (!tc->mode)
-               return -EINVAL;
-
        dev_dbg(tc->dev, "link enable\n");
 
        tc_read(DP0CTL, &value);