OSDN Git Service

io: fix QIONetListener memory leak
authorPaolo Bonzini <pbonzini@redhat.com>
Mon, 18 Dec 2017 08:53:08 +0000 (09:53 +0100)
committerDaniel P. Berrangé <berrange@redhat.com>
Thu, 15 Feb 2018 16:54:57 +0000 (16:54 +0000)
The sources array does not escape out of qio_net_listener_wait_client, so
we have to free it.

Reported by Coverity.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
io/net-listener.c

index 77a4e28..de38dfa 100644 (file)
@@ -234,6 +234,7 @@ QIOChannelSocket *qio_net_listener_wait_client(QIONetListener *listener)
     for (i = 0; i < listener->nsioc; i++) {
         g_source_unref(sources[i]);
     }
+    g_free(sources);
     g_main_loop_unref(loop);
     g_main_context_unref(ctxt);