OSDN Git Service

ocfs2/dlm: clean up deadcode in dlm_master_request_handler()
authorpiaojun <piaojun@huawei.com>
Tue, 13 Dec 2016 00:41:14 +0000 (16:41 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 13 Dec 2016 02:55:06 +0000 (18:55 -0800)
When 'dispatch_assert' is set, 'response' must be DLM_MASTER_RESP_YES,
and 'res' won't be null, so execution can't reach these two branch.

Link: http://lkml.kernel.org/r/58174C91.3040004@huawei.com
Signed-off-by: Jun Piao <piaojun@huawei.com>
Reviewed-by: Joseph Qi Joseph Qi <jiangqi903@gmail.com>
Cc: Mark Fasheh <mfasheh@versity.com>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Junxiao Bi <junxiao.bi@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/ocfs2/dlm/dlmmaster.c

index 0487dbc..a464c80 100644 (file)
@@ -1641,12 +1641,6 @@ send_response:
         * dlm_assert_master_worker() isn't called, we drop it here.
         */
        if (dispatch_assert) {
-               if (response != DLM_MASTER_RESP_YES)
-                       mlog(ML_ERROR, "invalid response %d\n", response);
-               if (!res) {
-                       mlog(ML_ERROR, "bad lockres while trying to assert!\n");
-                       BUG();
-               }
                mlog(0, "%u is the owner of %.*s, cleaning everyone else\n",
                             dlm->node_num, res->lockname.len, res->lockname.name);
                spin_lock(&res->spinlock);