OSDN Git Service

staging: iio: ad7150: simplify i2c SMBus return treatment
authorMelissa Wen <melissa.srw@gmail.com>
Fri, 14 Jun 2019 16:32:54 +0000 (13:32 -0300)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 17 Jun 2019 20:06:49 +0000 (21:06 +0100)
Since i2c_smbus_write_byte_data returns no-positive value, this commit
making the treatment of its return value less verbose.

Signed-off-by: Melissa Wen <melissa.srw@gmail.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/staging/iio/cdc/ad7150.c

index aa750a9..b91af73 100644 (file)
@@ -202,16 +202,11 @@ static int ad7150_write_event_params(struct iio_dev *indio_dev,
        ret = i2c_smbus_write_byte_data(chip->client,
                                        ad7150_addresses[chan][4],
                                        sens);
-       if (ret < 0)
+       if (ret)
                return ret;
-
-       ret = i2c_smbus_write_byte_data(chip->client,
+       return i2c_smbus_write_byte_data(chip->client,
                                        ad7150_addresses[chan][5],
                                        timeout);
-       if (ret < 0)
-               return ret;
-
-       return 0;
 }
 
 static int ad7150_write_event_config(struct iio_dev *indio_dev,