OSDN Git Service

sock_get_timeout: drop unnecessary return variable
authorVito Caputo <vcaputo@pengaru.com>
Thu, 10 Oct 2019 04:08:24 +0000 (21:08 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 12 Oct 2019 03:45:31 +0000 (20:45 -0700)
Remove pointless use of size return variable by directly returning
sizes.

Signed-off-by: Vito Caputo <vcaputo@pengaru.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/sock.c

index 24e9340..ceda6b1 100644 (file)
@@ -333,7 +333,6 @@ EXPORT_SYMBOL(__sk_backlog_rcv);
 static int sock_get_timeout(long timeo, void *optval, bool old_timeval)
 {
        struct __kernel_sock_timeval tv;
-       int size;
 
        if (timeo == MAX_SCHEDULE_TIMEOUT) {
                tv.tv_sec = 0;
@@ -354,13 +353,11 @@ static int sock_get_timeout(long timeo, void *optval, bool old_timeval)
                old_tv.tv_sec = tv.tv_sec;
                old_tv.tv_usec = tv.tv_usec;
                *(struct __kernel_old_timeval *)optval = old_tv;
-               size = sizeof(old_tv);
-       } else {
-               *(struct __kernel_sock_timeval *)optval = tv;
-               size = sizeof(tv);
+               return sizeof(old_tv);
        }
 
-       return size;
+       *(struct __kernel_sock_timeval *)optval = tv;
+       return sizeof(tv);
 }
 
 static int sock_set_timeout(long *timeo_p, char __user *optval, int optlen, bool old_timeval)