OSDN Git Service

qapi: Improve error message for description following section
authorMarkus Armbruster <armbru@redhat.com>
Wed, 10 May 2023 14:16:37 +0000 (16:16 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Mon, 22 May 2023 08:03:26 +0000 (10:03 +0200)
The error message is bad when the section is untagged.  For instance,
test case doc-interleaved-section produces "'@foobar:' can't follow
'Note' section", which is okay, but if we drop the "Note:" tag, we get
"'@foobar:' can't follow 'None' section, which is bad.

Change the error message to "description of '@foobar:' follows a
section".

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230510141637.3685080-1-armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
[Conflict with commit 3e32dca3f0d resolved]

scripts/qapi/parser.py
tests/qapi-schema/doc-interleaved-section.err

index 1ff334e..22e7bcc 100644 (file)
@@ -675,8 +675,8 @@ class QAPIDoc:
         match = self._match_at_name_colon(line)
         if match:
             raise QAPIParseError(self._parser,
-                                 "'@%s:' can't follow '%s' section"
-                                 % (match.group(1), self.sections[0].name))
+                                 "description of '@%s:' follows a section"
+                                 % match.group(1))
         match = self._match_section_tag(line)
         if match:
             line = line[match.end():]
index 715d58c..e5d1ef5 100644 (file)
@@ -1 +1 @@
-doc-interleaved-section.json:15:1: '@foobar:' can't follow 'Note' section
+doc-interleaved-section.json:15:1: description of '@foobar:' follows a section