scsi: atp870u: 64 bit bug in atp885_init()

On 64 bit CPUs there is a memory corruption bug on probe().  It should
be a u32 pointer instead of an unsigned long pointer or we write past
the end of the setupdata[] array.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/atp870u.c b/drivers/scsi/atp870u.c
index 8b52a9d..b46997c 100644 (file)
--- a/drivers/scsi/atp870u.c
+++ b/drivers/scsi/atp870u.c
@@ -1413,11 +1413,11 @@ static void atp885_init(struct Scsi_Host *shpnt)
                        atpdev->global_map[m] = 0;
                        for (k = 0; k < 4; k++) {
                                atp_writew_base(atpdev, 0x3c, n++);
-                               ((unsigned long *)&setupdata[m][0])[k] = atp_readl_base(atpdev, 0x38);
+                               ((u32 *)&setupdata[m][0])[k] = atp_readl_base(atpdev, 0x38);
                        }
                        for (k = 0; k < 4; k++) {
                                atp_writew_base(atpdev, 0x3c, n++);
-                               ((unsigned long *)&atpdev->sp[m][0])[k] = atp_readl_base(atpdev, 0x38);
+                               ((u32 *)&atpdev->sp[m][0])[k] = atp_readl_base(atpdev, 0x38);
                        }
                        n += 8;
                }