OSDN Git Service

scsi: be2iscsi: Remove wq_name from beiscsi_hba
authorJitendra Bhivare <jitendra.bhivare@broadcom.com>
Tue, 13 Dec 2016 10:26:02 +0000 (15:56 +0530)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 5 Jan 2017 05:21:13 +0000 (00:21 -0500)
wq_name is used only to set WQ name when its being allocated.
Remove it from beiscsi_hba structure and define locally.

Signed-off-by: Jitendra Bhivare <jitendra.bhivare@broadcom.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/be2iscsi/be_main.c
drivers/scsi/be2iscsi/be_main.h

index a8e67c6..a68f1be 100644 (file)
@@ -5623,11 +5623,12 @@ static void beiscsi_eeh_resume(struct pci_dev *pdev)
 static int beiscsi_dev_probe(struct pci_dev *pcidev,
                             const struct pci_device_id *id)
 {
-       struct beiscsi_hba *phba = NULL;
-       struct hwi_controller *phwi_ctrlr;
        struct hwi_context_memory *phwi_context;
+       struct hwi_controller *phwi_ctrlr;
+       struct beiscsi_hba *phba = NULL;
        struct be_eq_obj *pbe_eq;
        unsigned int s_handle;
+       char wq_name[20];
        int ret, i;
 
        ret = beiscsi_enable_pci(pcidev);
@@ -5739,9 +5740,9 @@ static int beiscsi_dev_probe(struct pci_dev *pcidev,
 
        phba->ctrl.mcc_alloc_index = phba->ctrl.mcc_free_index = 0;
 
-       snprintf(phba->wq_name, sizeof(phba->wq_name), "beiscsi_%02x_wq",
+       snprintf(wq_name, sizeof(wq_name), "beiscsi_%02x_wq",
                 phba->shost->host_no);
-       phba->wq = alloc_workqueue("%s", WQ_MEM_RECLAIM, 1, phba->wq_name);
+       phba->wq = alloc_workqueue("%s", WQ_MEM_RECLAIM, 1, wq_name);
        if (!phba->wq) {
                beiscsi_log(phba, KERN_ERR, BEISCSI_LOG_INIT,
                            "BM_%d : beiscsi_dev_probe-"
index 73cc2f7..30379de 100644 (file)
@@ -410,7 +410,6 @@ struct beiscsi_hba {
        u8 port_name;
        u8 port_speed;
        char fw_ver_str[BEISCSI_VER_STRLEN];
-       char wq_name[20];
        struct workqueue_struct *wq;    /* The actuak work queue */
        struct be_ctrl_info ctrl;
        unsigned int generation;