OSDN Git Service

ravb: simplify link auto-negotiation by ethtool
authorVladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Wed, 4 Jul 2018 08:16:08 +0000 (11:16 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sat, 7 Jul 2018 01:44:09 +0000 (10:44 +0900)
There is no need to call a heavyweight phy_start_aneg() for phy
auto-negotiation by ethtool, the phy is already initialized and
link auto-negotiation is started by calling phy_start() from
ravb_phy_start() when a network device is opened.

Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Reviewed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/renesas/ravb_main.c

index 40266fe..31913a4 100644 (file)
@@ -1136,7 +1136,7 @@ static int ravb_nway_reset(struct net_device *ndev)
        int error = -ENODEV;
 
        if (ndev->phydev)
-               error = phy_start_aneg(ndev->phydev);
+               error = phy_restart_aneg(ndev->phydev);
 
        return error;
 }