OSDN Git Service

Fixing crash when using app name comparator with empty titles.
authorWinson Chung <winsonc@google.com>
Thu, 25 Jun 2015 17:05:54 +0000 (10:05 -0700)
committerWinson Chung <winsonc@google.com>
Thu, 25 Jun 2015 17:05:54 +0000 (10:05 -0700)
Bug: 22065752
Change-Id: I4160f5e1728e46ce85fd2579889e7952de01a752

src/com/android/launcher3/model/AppNameComparator.java

index cd45d2c..c4b74d4 100644 (file)
@@ -85,8 +85,10 @@ public class AppNameComparator {
      */
     @Thunk int compareTitles(String titleA, String titleB) {
         // Ensure that we de-prioritize any titles that don't start with a linguistic letter or digit
-        boolean aStartsWithLetter = Character.isLetterOrDigit(titleA.codePointAt(0));
-        boolean bStartsWithLetter = Character.isLetterOrDigit(titleB.codePointAt(0));
+        boolean aStartsWithLetter = (titleA.length() > 0) &&
+                Character.isLetterOrDigit(titleA.codePointAt(0));
+        boolean bStartsWithLetter = (titleB.length() > 0) &&
+                Character.isLetterOrDigit(titleB.codePointAt(0));
         if (aStartsWithLetter && !bStartsWithLetter) {
             return -1;
         } else if (!aStartsWithLetter && bStartsWithLetter) {