OSDN Git Service

staging: vt6655: Use loop in vt6655_mac_read_ether_addr
authorPhilipp Hortmann <philipp.g.hortmann@gmail.com>
Wed, 6 Jul 2022 19:19:06 +0000 (21:19 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Jul 2022 12:29:22 +0000 (14:29 +0200)
Use loop in vt6655_mac_read_ether_addr to avoid multiple
similar statements.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/f233c8a007d75a8adcc99a07c582b75bdc1985db.1657134099.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vt6655/device_main.c

index 099f0b9..19840dd 100644 (file)
@@ -200,12 +200,8 @@ static void vt6655_mac_write_bssid_addr(void __iomem *iobase, const u8 *mac_addr
 static void vt6655_mac_read_ether_addr(void __iomem *iobase, u8 *mac_addr)
 {
        iowrite8(1, iobase + MAC_REG_PAGE1SEL);
-       mac_addr[0] = ioread8(iobase + MAC_REG_PAR0);
-       mac_addr[1] = ioread8(iobase + MAC_REG_PAR0 + 1);
-       mac_addr[2] = ioread8(iobase + MAC_REG_PAR0 + 2);
-       mac_addr[3] = ioread8(iobase + MAC_REG_PAR0 + 3);
-       mac_addr[4] = ioread8(iobase + MAC_REG_PAR0 + 4);
-       mac_addr[5] = ioread8(iobase + MAC_REG_PAR0 + 5);
+       for (int i = 0; i < 6; i++)
+               mac_addr[i] = ioread8(iobase + MAC_REG_PAR0 + i);
        iowrite8(0, iobase + MAC_REG_PAGE1SEL);
 }