OSDN Git Service

drm/i915/psr/cnl: Set y-coordinate as valid in SDP
authorJosé Roberto de Souza <jose.souza@intel.com>
Wed, 25 Apr 2018 21:23:34 +0000 (14:23 -0700)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Thu, 26 Apr 2018 22:36:18 +0000 (15:36 -0700)
This was my bad, spec says that the name of this bit is
'Y-coordinate valid' but the values for it is:
0: Include Y-coordinate valid eDP1.4a
1: Do not include Y-coordinate valid eDP 1.4
So not setting it.

BSpec: 7713

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180425212334.21109-4-jose.souza@intel.com
drivers/gpu/drm/i915/intel_psr.c

index c8d5cdc..6233a32 100644 (file)
@@ -508,9 +508,8 @@ static void hsw_activate_psr2(struct intel_dp *intel_dp)
         * mesh at all with our frontbuffer tracking. And the hw alone isn't
         * good enough. */
        val |= EDP_PSR2_ENABLE | EDP_SU_TRACK_ENABLE;
-       if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv)) {
-               val |= EDP_Y_COORDINATE_VALID | EDP_Y_COORDINATE_ENABLE;
-       }
+       if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv))
+               val |= EDP_Y_COORDINATE_ENABLE;
 
        val |= EDP_PSR2_FRAME_BEFORE_SU(dev_priv->psr.sink_sync_latency + 1);