OSDN Git Service

scsi: flip the default on use_clustering
authorChristoph Hellwig <hch@lst.de>
Thu, 13 Dec 2018 15:17:02 +0000 (16:17 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 19 Dec 2018 04:13:12 +0000 (23:13 -0500)
Most SCSI drivers want to enable "clustering", that is merging of
segments so that they might span more than a single page.  Remove the
ENABLE_CLUSTERING define, and require drivers to explicitly set
DISABLE_CLUSTERING to disable this feature.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
82 files changed:
drivers/firewire/sbp2.c
drivers/infiniband/ulp/iser/iscsi_iser.c
drivers/infiniband/ulp/srp/ib_srp.c
drivers/message/fusion/mptfc.c
drivers/message/fusion/mptsas.c
drivers/message/fusion/mptspi.c
drivers/s390/scsi/zfcp_scsi.c
drivers/scsi/3w-9xxx.c
drivers/scsi/3w-sas.c
drivers/scsi/3w-xxxx.c
drivers/scsi/53c700.c
drivers/scsi/BusLogic.c
drivers/scsi/a100u2w.c
drivers/scsi/a3000.c
drivers/scsi/aacraid/linit.c
drivers/scsi/advansys.c
drivers/scsi/aha1542.c
drivers/scsi/aha1740.c
drivers/scsi/aic7xxx/aic79xx_osm.c
drivers/scsi/aic7xxx/aic7xxx_osm.c
drivers/scsi/aic94xx/aic94xx_init.c
drivers/scsi/arcmsr/arcmsr_hba.c
drivers/scsi/arm/powertec.c
drivers/scsi/atp870u.c
drivers/scsi/be2iscsi/be_main.c
drivers/scsi/bfa/bfad_im.c
drivers/scsi/bnx2fc/bnx2fc_fcoe.c
drivers/scsi/bnx2i/bnx2i_iscsi.c
drivers/scsi/csiostor/csio_scsi.c
drivers/scsi/cxlflash/main.c
drivers/scsi/dpt_i2o.c
drivers/scsi/esas2r/esas2r_main.c
drivers/scsi/esp_scsi.c
drivers/scsi/fcoe/fcoe.c
drivers/scsi/fnic/fnic_main.c
drivers/scsi/gdth.c
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
drivers/scsi/hpsa.c
drivers/scsi/hptiop.c
drivers/scsi/ibmvscsi/ibmvfc.c
drivers/scsi/ibmvscsi/ibmvscsi.c
drivers/scsi/imm.c
drivers/scsi/initio.c
drivers/scsi/ipr.c
drivers/scsi/ips.c
drivers/scsi/isci/init.c
drivers/scsi/lpfc/lpfc_scsi.c
drivers/scsi/megaraid.c
drivers/scsi/megaraid/megaraid_mbox.c
drivers/scsi/megaraid/megaraid_sas_base.c
drivers/scsi/mpt3sas/mpt3sas_scsih.c
drivers/scsi/mvme147.c
drivers/scsi/mvsas/mv_init.c
drivers/scsi/ncr53c8xx.c
drivers/scsi/pcmcia/sym53c500_cs.c
drivers/scsi/pm8001/pm8001_init.c
drivers/scsi/pmcraid.c
drivers/scsi/ppa.c
drivers/scsi/ps3rom.c
drivers/scsi/qedf/qedf_main.c
drivers/scsi/qedi/qedi_iscsi.c
drivers/scsi/qla1280.c
drivers/scsi/qla2xxx/qla_os.c
drivers/scsi/qla4xxx/ql4_os.c
drivers/scsi/qlogicpti.c
drivers/scsi/scsi_debug.c
drivers/scsi/scsi_lib.c
drivers/scsi/smartpqi/smartpqi_init.c
drivers/scsi/snic/snic_main.c
drivers/scsi/storvsc_drv.c
drivers/scsi/sym53c8xx_2/sym_glue.c
drivers/scsi/virtio_scsi.c
drivers/scsi/vmw_pvscsi.c
drivers/scsi/wd719x.c
drivers/staging/rts5208/rtsx.c
drivers/staging/unisys/visorhba/visorhba_main.c
drivers/usb/image/microtek.c
drivers/usb/storage/scsiglue.c
include/linux/libata.h
include/scsi/scsi_host.h

index 6bac039..09b845e 100644 (file)
@@ -1610,7 +1610,6 @@ static struct scsi_host_template scsi_driver_template = {
        .eh_abort_handler       = sbp2_scsi_abort,
        .this_id                = -1,
        .sg_tablesize           = SG_ALL,
-       .use_clustering         = ENABLE_CLUSTERING,
        .can_queue              = 1,
        .sdev_attrs             = sbp2_scsi_sysfs_attrs,
 };
index 3fecd87..8c707ac 100644 (file)
@@ -997,7 +997,6 @@ static struct scsi_host_template iscsi_iser_sht = {
        .eh_device_reset_handler= iscsi_eh_device_reset,
        .eh_target_reset_handler = iscsi_eh_recover_target,
        .target_alloc           = iscsi_target_alloc,
-       .use_clustering         = ENABLE_CLUSTERING,
        .slave_alloc            = iscsi_iser_slave_alloc,
        .proc_name              = "iscsi_iser",
        .this_id                = -1,
index eed0eb3..d27fe97 100644 (file)
@@ -3215,7 +3215,6 @@ static struct scsi_host_template srp_template = {
        .can_queue                      = SRP_DEFAULT_CMD_SQ_SIZE,
        .this_id                        = -1,
        .cmd_per_lun                    = SRP_DEFAULT_CMD_SQ_SIZE,
-       .use_clustering                 = ENABLE_CLUSTERING,
        .shost_attrs                    = srp_host_attrs,
        .track_queue_depth              = 1,
 };
index b15fdc6..4314a33 100644 (file)
@@ -129,7 +129,6 @@ static struct scsi_host_template mptfc_driver_template = {
        .sg_tablesize                   = MPT_SCSI_SG_DEPTH,
        .max_sectors                    = 8192,
        .cmd_per_lun                    = 7,
-       .use_clustering                 = ENABLE_CLUSTERING,
        .shost_attrs                    = mptscsih_host_attrs,
 };
 
index 9b404fc..612cb5b 100644 (file)
@@ -1992,7 +1992,6 @@ static struct scsi_host_template mptsas_driver_template = {
        .sg_tablesize                   = MPT_SCSI_SG_DEPTH,
        .max_sectors                    = 8192,
        .cmd_per_lun                    = 7,
-       .use_clustering                 = ENABLE_CLUSTERING,
        .shost_attrs                    = mptscsih_host_attrs,
        .no_write_same                  = 1,
 };
index 9a336a1..7172b0b 100644 (file)
@@ -848,7 +848,6 @@ static struct scsi_host_template mptspi_driver_template = {
        .sg_tablesize                   = MPT_SCSI_SG_DEPTH,
        .max_sectors                    = 8192,
        .cmd_per_lun                    = 7,
-       .use_clustering                 = ENABLE_CLUSTERING,
        .shost_attrs                    = mptscsih_host_attrs,
 };
 
index a8b53ed..00acc71 100644 (file)
@@ -429,7 +429,6 @@ static struct scsi_host_template zfcp_scsi_host_template = {
                                     * ZFCP_QDIO_MAX_SBALS_PER_REQ) - 2) * 8,
                                   /* GCD, adjusted later */
        .dma_boundary            = ZFCP_QDIO_SBALE_LEN - 1,
-       .use_clustering          = 1,
        .shost_attrs             = zfcp_sysfs_shost_attrs,
        .sdev_attrs              = zfcp_sysfs_sdev_attrs,
        .track_queue_depth       = 1,
index 2d655a9..a3c20e3 100644 (file)
@@ -1998,7 +1998,6 @@ static struct scsi_host_template driver_template = {
        .sg_tablesize           = TW_APACHE_MAX_SGL_LENGTH,
        .max_sectors            = TW_MAX_SECTORS,
        .cmd_per_lun            = TW_MAX_CMDS_PER_LUN,
-       .use_clustering         = ENABLE_CLUSTERING,
        .shost_attrs            = twa_host_attrs,
        .emulated               = 1,
        .no_write_same          = 1,
index 480cf82..e8f5f7c 100644 (file)
@@ -1550,7 +1550,6 @@ static struct scsi_host_template driver_template = {
        .sg_tablesize           = TW_LIBERATOR_MAX_SGL_LENGTH,
        .max_sectors            = TW_MAX_SECTORS,
        .cmd_per_lun            = TW_MAX_CMDS_PER_LUN,
-       .use_clustering         = ENABLE_CLUSTERING,
        .shost_attrs            = twl_host_attrs,
        .emulated               = 1,
        .no_write_same          = 1,
index a582576..4938ba8 100644 (file)
@@ -2247,7 +2247,6 @@ static struct scsi_host_template driver_template = {
        .sg_tablesize           = TW_MAX_SGL_LENGTH,
        .max_sectors            = TW_MAX_SECTORS,
        .cmd_per_lun            = TW_MAX_CMDS_PER_LUN,  
-       .use_clustering         = ENABLE_CLUSTERING,
        .shost_attrs            = tw_host_attrs,
        .emulated               = 1,
        .no_write_same          = 1,
index 6be77b3..128d658 100644 (file)
@@ -318,7 +318,6 @@ NCR_700_detect(struct scsi_host_template *tpnt,
        tpnt->can_queue = NCR_700_COMMAND_SLOTS_PER_HOST;
        tpnt->sg_tablesize = NCR_700_SG_SEGMENTS;
        tpnt->cmd_per_lun = NCR_700_CMD_PER_LUN;
-       tpnt->use_clustering = ENABLE_CLUSTERING;
        tpnt->slave_configure = NCR_700_slave_configure;
        tpnt->slave_destroy = NCR_700_slave_destroy;
        tpnt->slave_alloc = NCR_700_slave_alloc;
index 717eef3..e41e51f 100644 (file)
@@ -3858,7 +3858,6 @@ static struct scsi_host_template blogic_template = {
 #endif
        .unchecked_isa_dma = 1,
        .max_sectors = 128,
-       .use_clustering = ENABLE_CLUSTERING,
 };
 
 /*
index 00072ed..ff53fd0 100644 (file)
@@ -1078,7 +1078,6 @@ static struct scsi_host_template inia100_template = {
        .can_queue              = 1,
        .this_id                = 1,
        .sg_tablesize           = SG_ALL,
-       .use_clustering         = ENABLE_CLUSTERING,
 };
 
 static int inia100_probe_one(struct pci_dev *pdev,
index 2427a85..dcf435f 100644 (file)
@@ -175,7 +175,6 @@ static struct scsi_host_template amiga_a3000_scsi_template = {
        .this_id                = 7,
        .sg_tablesize           = SG_ALL,
        .cmd_per_lun            = CMD_PER_LUN,
-       .use_clustering         = ENABLE_CLUSTERING
 };
 
 static int __init amiga_a3000_scsi_probe(struct platform_device *pdev)
index 1c5d54c..634ddb9 100644 (file)
@@ -1540,7 +1540,6 @@ static struct scsi_host_template aac_driver_template = {
 #else
        .cmd_per_lun                    = AAC_NUM_IO_FIB,
 #endif
-       .use_clustering                 = ENABLE_CLUSTERING,
        .emulated                       = 1,
        .no_write_same                  = 1,
 };
index 223ef6f..95b4793 100644 (file)
@@ -10808,14 +10808,6 @@ static struct scsi_host_template advansys_template = {
         * for non-ISA adapters.
         */
        .unchecked_isa_dma = true,
-       /*
-        * All adapters controlled by this driver are capable of large
-        * scatter-gather lists. According to the mid-level SCSI documentation
-        * this obviates any performance gain provided by setting
-        * 'use_clustering'. But empirically while CPU utilization is increased
-        * by enabling clustering, I/O throughput increases as well.
-        */
-       .use_clustering = ENABLE_CLUSTERING,
 };
 
 static int advansys_wide_init_chip(struct Scsi_Host *shost)
index afb693d..ba7a572 100644 (file)
@@ -1011,7 +1011,6 @@ static struct scsi_host_template driver_template = {
        .this_id                = 7,
        .sg_tablesize           = 16,
        .unchecked_isa_dma      = 1, 
-       .use_clustering         = ENABLE_CLUSTERING,
 };
 
 static int aha1542_isa_match(struct device *pdev, unsigned int ndev)
index 786bf7f..da4150c 100644 (file)
@@ -545,7 +545,6 @@ static struct scsi_host_template aha1740_template = {
        .can_queue        = AHA1740_ECBS,
        .this_id          = 7,
        .sg_tablesize     = AHA1740_SCATTER,
-       .use_clustering   = ENABLE_CLUSTERING,
        .eh_abort_handler = aha1740_eh_abort_handler,
 };
 
index 2588b8f..5799251 100644 (file)
@@ -920,7 +920,6 @@ struct scsi_host_template aic79xx_driver_template = {
        .this_id                = -1,
        .max_sectors            = 8192,
        .cmd_per_lun            = 2,
-       .use_clustering         = ENABLE_CLUSTERING,
        .slave_alloc            = ahd_linux_slave_alloc,
        .slave_configure        = ahd_linux_slave_configure,
        .target_alloc           = ahd_linux_target_alloc,
index c6be3ae..3c9c174 100644 (file)
@@ -807,7 +807,6 @@ struct scsi_host_template aic7xxx_driver_template = {
        .this_id                = -1,
        .max_sectors            = 8192,
        .cmd_per_lun            = 2,
-       .use_clustering         = ENABLE_CLUSTERING,
        .slave_alloc            = ahc_linux_slave_alloc,
        .slave_configure        = ahc_linux_slave_configure,
        .target_alloc           = ahc_linux_target_alloc,
index 41c4d8a..f83f79b 100644 (file)
@@ -68,7 +68,6 @@ static struct scsi_host_template aic94xx_sht = {
        .this_id                = -1,
        .sg_tablesize           = SG_ALL,
        .max_sectors            = SCSI_DEFAULT_MAX_SECTORS,
-       .use_clustering         = ENABLE_CLUSTERING,
        .eh_device_reset_handler        = sas_eh_device_reset_handler,
        .eh_target_reset_handler        = sas_eh_target_reset_handler,
        .target_destroy         = sas_target_destroy,
index 11e8e6d..0f6751b 100644 (file)
@@ -156,7 +156,6 @@ static struct scsi_host_template arcmsr_scsi_host_template = {
        .sg_tablesize           = ARCMSR_DEFAULT_SG_ENTRIES,
        .max_sectors            = ARCMSR_MAX_XFER_SECTORS_C,
        .cmd_per_lun            = ARCMSR_DEFAULT_CMD_PERLUN,
-       .use_clustering         = ENABLE_CLUSTERING,
        .shost_attrs            = arcmsr_host_attrs,
        .no_write_same          = 1,
 };
index 79aa889..759f95b 100644 (file)
@@ -294,7 +294,6 @@ static struct scsi_host_template powertecscsi_template = {
        .sg_tablesize                   = SG_MAX_SEGMENTS,
        .dma_boundary                   = IOMD_DMA_BOUNDARY,
        .cmd_per_lun                    = 2,
-       .use_clustering                 = ENABLE_CLUSTERING,
        .proc_name                      = "powertec",
 };
 
index 802d150..1267200 100644 (file)
@@ -1681,7 +1681,6 @@ static struct scsi_host_template atp870u_template = {
      .can_queue                = qcnt                  /* can_queue */,
      .this_id                  = 7                     /* SCSI ID */,
      .sg_tablesize             = ATP870U_SCATTER       /*SG_ALL*/ /*SG_NONE*/,
-     .use_clustering           = ENABLE_CLUSTERING,
      .max_sectors              = ATP870U_MAX_SECTORS,
 };
 
index effb6fc..c4108b1 100644 (file)
@@ -405,7 +405,6 @@ static struct scsi_host_template beiscsi_sht = {
        .this_id = -1,
        .max_sectors = BEISCSI_MAX_SECTORS,
        .cmd_per_lun = BEISCSI_CMD_PER_LUN,
-       .use_clustering = ENABLE_CLUSTERING,
        .vendor_id = SCSI_NL_VID_TYPE_PCI | BE_VENDOR_ID,
        .track_queue_depth = 1,
 };
index c4a3331..394930c 100644 (file)
@@ -817,7 +817,6 @@ struct scsi_host_template bfad_im_scsi_host_template = {
        .this_id = -1,
        .sg_tablesize = BFAD_IO_MAX_SGE,
        .cmd_per_lun = 3,
-       .use_clustering = ENABLE_CLUSTERING,
        .shost_attrs = bfad_im_host_attrs,
        .max_sectors = BFAD_MAX_SECTORS,
        .vendor_id = BFA_PCI_VENDOR_ID_BROCADE,
@@ -840,7 +839,6 @@ struct scsi_host_template bfad_im_vport_template = {
        .this_id = -1,
        .sg_tablesize = BFAD_IO_MAX_SGE,
        .cmd_per_lun = 3,
-       .use_clustering = ENABLE_CLUSTERING,
        .shost_attrs = bfad_im_vport_attrs,
        .max_sectors = BFAD_MAX_SECTORS,
 };
index cd160f2..63f76e2 100644 (file)
@@ -2970,7 +2970,6 @@ static struct scsi_host_template bnx2fc_shost_template = {
        .change_queue_depth     = scsi_change_queue_depth,
        .this_id                = -1,
        .cmd_per_lun            = 3,
-       .use_clustering         = ENABLE_CLUSTERING,
        .sg_tablesize           = BNX2FC_MAX_BDS_PER_CMD,
        .max_sectors            = 1024,
        .track_queue_depth      = 1,
index de0a507..69c7542 100644 (file)
@@ -2263,7 +2263,6 @@ static struct scsi_host_template bnx2i_host_template = {
        .max_sectors            = 127,
        .cmd_per_lun            = 128,
        .this_id                = -1,
-       .use_clustering         = ENABLE_CLUSTERING,
        .sg_tablesize           = ISCSI_MAX_BDS_PER_CMD,
        .shost_attrs            = bnx2i_dev_attributes,
        .track_queue_depth      = 1,
index 8c15b7a..e67555e 100644 (file)
@@ -2280,7 +2280,6 @@ struct scsi_host_template csio_fcoe_shost_template = {
        .this_id                = -1,
        .sg_tablesize           = CSIO_SCSI_MAX_SGE,
        .cmd_per_lun            = CSIO_MAX_CMD_PER_LUN,
-       .use_clustering         = ENABLE_CLUSTERING,
        .shost_attrs            = csio_fcoe_lport_attrs,
        .max_sectors            = CSIO_MAX_SECTOR_SIZE,
 };
@@ -2300,7 +2299,6 @@ struct scsi_host_template csio_fcoe_shost_vport_template = {
        .this_id                = -1,
        .sg_tablesize           = CSIO_SCSI_MAX_SGE,
        .cmd_per_lun            = CSIO_MAX_CMD_PER_LUN,
-       .use_clustering         = ENABLE_CLUSTERING,
        .shost_attrs            = csio_fcoe_vport_attrs,
        .max_sectors            = CSIO_MAX_SECTOR_SIZE,
 };
index 6637116..6996d15 100644 (file)
@@ -3180,7 +3180,6 @@ static struct scsi_host_template driver_template = {
        .this_id = -1,
        .sg_tablesize = 1,      /* No scatter gather support */
        .max_sectors = CXLFLASH_MAX_SECTORS,
-       .use_clustering = ENABLE_CLUSTERING,
        .shost_attrs = cxlflash_host_attrs,
        .sdev_attrs = cxlflash_dev_attrs,
 };
index d5a474d..70d1a18 100644 (file)
@@ -3569,7 +3569,6 @@ static struct scsi_host_template driver_template = {
        .slave_configure        = adpt_slave_configure,
        .can_queue              = MAX_TO_IOP_MESSAGES,
        .this_id                = 7,
-       .use_clustering         = ENABLE_CLUSTERING,
 };
 
 static int __init adpt_init(void)
index c071186..64397d4 100644 (file)
@@ -250,7 +250,6 @@ static struct scsi_host_template driver_template = {
                ESAS2R_DEFAULT_CMD_PER_LUN,
        .present                        = 0,
        .unchecked_isa_dma              = 0,
-       .use_clustering                 = ENABLE_CLUSTERING,
        .emulated                       = 0,
        .proc_name                      = ESAS2R_DRVR_NAME,
        .change_queue_depth             = scsi_change_queue_depth,
index ac7da9d..465df47 100644 (file)
@@ -2676,7 +2676,6 @@ struct scsi_host_template scsi_esp_template = {
        .can_queue              = 7,
        .this_id                = 7,
        .sg_tablesize           = SG_ALL,
-       .use_clustering         = ENABLE_CLUSTERING,
        .max_sectors            = 0xffff,
        .skip_settle_delay      = 1,
 };
index f46b312..4961ae4 100644 (file)
@@ -286,7 +286,6 @@ static struct scsi_host_template fcoe_shost_template = {
        .this_id = -1,
        .cmd_per_lun = 3,
        .can_queue = FCOE_MAX_OUTSTANDING_COMMANDS,
-       .use_clustering = ENABLE_CLUSTERING,
        .sg_tablesize = SG_ALL,
        .max_sectors = 0xffff,
        .track_queue_depth = 1,
index cc461fd..5b3534b 100644 (file)
@@ -115,7 +115,6 @@ static struct scsi_host_template fnic_host_template = {
        .this_id = -1,
        .cmd_per_lun = 3,
        .can_queue = FNIC_DFLT_IO_REQ,
-       .use_clustering = ENABLE_CLUSTERING,
        .sg_tablesize = FNIC_MAX_SG_DESC_CNT,
        .max_sectors = 0xffff,
        .shost_attrs = fnic_attrs,
index 1670973..194c294 100644 (file)
@@ -4680,7 +4680,6 @@ static struct scsi_host_template gdth_template = {
         .sg_tablesize           = GDTH_MAXSG,
         .cmd_per_lun            = GDTH_MAXC_P_L,
         .unchecked_isa_dma      = 1,
-        .use_clustering         = ENABLE_CLUSTERING,
        .no_write_same          = 1,
 };
 
index 107f7c9..95a1ddf 100644 (file)
@@ -1818,7 +1818,6 @@ static struct scsi_host_template sht_v1_hw = {
        .this_id                = -1,
        .sg_tablesize           = HISI_SAS_SGE_PAGE_CNT,
        .max_sectors            = SCSI_DEFAULT_MAX_SECTORS,
-       .use_clustering         = ENABLE_CLUSTERING,
        .eh_device_reset_handler = sas_eh_device_reset_handler,
        .eh_target_reset_handler = sas_eh_target_reset_handler,
        .target_destroy         = sas_target_destroy,
index 8760987..9083205 100644 (file)
@@ -3580,7 +3580,6 @@ static struct scsi_host_template sht_v2_hw = {
        .this_id                = -1,
        .sg_tablesize           = HISI_SAS_SGE_PAGE_CNT,
        .max_sectors            = SCSI_DEFAULT_MAX_SECTORS,
-       .use_clustering         = ENABLE_CLUSTERING,
        .eh_device_reset_handler = sas_eh_device_reset_handler,
        .eh_target_reset_handler = sas_eh_target_reset_handler,
        .target_destroy         = sas_target_destroy,
index 44781e3..6acca89 100644 (file)
@@ -2233,7 +2233,6 @@ static struct scsi_host_template sht_v3_hw = {
        .this_id                = -1,
        .sg_tablesize           = HISI_SAS_SGE_PAGE_CNT,
        .max_sectors            = SCSI_DEFAULT_MAX_SECTORS,
-       .use_clustering         = ENABLE_CLUSTERING,
        .eh_device_reset_handler = sas_eh_device_reset_handler,
        .eh_target_reset_handler = sas_eh_target_reset_handler,
        .target_destroy         = sas_target_destroy,
index bc64e8a..ff67ef5 100644 (file)
@@ -965,7 +965,6 @@ static struct scsi_host_template hpsa_driver_template = {
        .scan_finished          = hpsa_scan_finished,
        .change_queue_depth     = hpsa_change_queue_depth,
        .this_id                = -1,
-       .use_clustering         = ENABLE_CLUSTERING,
        .eh_device_reset_handler = hpsa_eh_device_reset_handler,
        .ioctl                  = hpsa_ioctl,
        .slave_alloc            = hpsa_slave_alloc,
index dc52b37..3eedfd4 100644 (file)
@@ -1180,7 +1180,6 @@ static struct scsi_host_template driver_template = {
        .eh_host_reset_handler      = hptiop_reset,
        .info                       = hptiop_info,
        .emulated                   = 0,
-       .use_clustering             = ENABLE_CLUSTERING,
        .proc_name                  = driver_name,
        .shost_attrs                = hptiop_attrs,
        .slave_configure            = hptiop_slave_config,
index b64ca97..dbaa4f1 100644 (file)
@@ -3100,7 +3100,6 @@ static struct scsi_host_template driver_template = {
        .this_id = -1,
        .sg_tablesize = SG_ALL,
        .max_sectors = IBMVFC_MAX_SECTORS,
-       .use_clustering = ENABLE_CLUSTERING,
        .shost_attrs = ibmvfc_attrs,
        .track_queue_depth = 1,
 };
index 9df8a1a..1135e74 100644 (file)
@@ -2079,7 +2079,6 @@ static struct scsi_host_template driver_template = {
        .can_queue = IBMVSCSI_MAX_REQUESTS_DEFAULT,
        .this_id = -1,
        .sg_tablesize = SG_ALL,
-       .use_clustering = ENABLE_CLUSTERING,
        .shost_attrs = ibmvscsi_attrs,
 };
 
index 8c6627b..cea7f50 100644 (file)
@@ -1110,7 +1110,6 @@ static struct scsi_host_template imm_template = {
        .bios_param             = imm_biosparam,
        .this_id                = 7,
        .sg_tablesize           = SG_ALL,
-       .use_clustering         = ENABLE_CLUSTERING,
        .can_queue              = 1,
        .slave_alloc            = imm_adjust_queue,
 };
index 0a8d786..eb2778b 100644 (file)
@@ -2817,7 +2817,6 @@ static struct scsi_host_template initio_template = {
        .can_queue              = MAX_TARGETS * i91u_MAXQUEUE,
        .this_id                = 1,
        .sg_tablesize           = SG_ALL,
-       .use_clustering         = ENABLE_CLUSTERING,
 };
 
 static int initio_probe_one(struct pci_dev *pdev,
index 271990b..d1b4025 100644 (file)
@@ -6754,7 +6754,6 @@ static struct scsi_host_template driver_template = {
        .sg_tablesize = IPR_MAX_SGLIST,
        .max_sectors = IPR_IOA_MAX_SECTORS,
        .cmd_per_lun = IPR_MAX_CMD_PER_LUN,
-       .use_clustering = ENABLE_CLUSTERING,
        .shost_attrs = ipr_ioa_attrs,
        .sdev_attrs = ipr_dev_attrs,
        .proc_name = IPR_NAME,
index 70a776d..0677252 100644 (file)
@@ -365,7 +365,6 @@ static struct scsi_host_template ips_driver_template = {
        .this_id                = -1,
        .sg_tablesize           = IPS_MAX_SG,
        .cmd_per_lun            = 3,
-       .use_clustering         = ENABLE_CLUSTERING,
        .no_write_same          = 1,
 };
 
index d72edbc..68b90c4 100644 (file)
@@ -163,7 +163,6 @@ static struct scsi_host_template isci_sht = {
        .this_id                        = -1,
        .sg_tablesize                   = SG_ALL,
        .max_sectors                    = SCSI_DEFAULT_MAX_SECTORS,
-       .use_clustering                 = ENABLE_CLUSTERING,
        .eh_abort_handler               = sas_eh_abort_handler,
        .eh_device_reset_handler        = sas_eh_device_reset_handler,
        .eh_target_reset_handler        = sas_eh_target_reset_handler,
index 14a6225..473d255 100644 (file)
@@ -6054,7 +6054,6 @@ struct scsi_host_template lpfc_template_nvme = {
        .this_id                = -1,
        .sg_tablesize           = 1,
        .cmd_per_lun            = 1,
-       .use_clustering         = ENABLE_CLUSTERING,
        .shost_attrs            = lpfc_hba_attrs,
        .max_sectors            = 0xFFFF,
        .vendor_id              = LPFC_NL_VENDOR_ID,
@@ -6079,7 +6078,6 @@ struct scsi_host_template lpfc_template_no_hr = {
        .this_id                = -1,
        .sg_tablesize           = LPFC_DEFAULT_SG_SEG_CNT,
        .cmd_per_lun            = LPFC_CMD_PER_LUN,
-       .use_clustering         = ENABLE_CLUSTERING,
        .shost_attrs            = lpfc_hba_attrs,
        .max_sectors            = 0xFFFF,
        .vendor_id              = LPFC_NL_VENDOR_ID,
@@ -6106,7 +6104,6 @@ struct scsi_host_template lpfc_template = {
        .this_id                = -1,
        .sg_tablesize           = LPFC_DEFAULT_SG_SEG_CNT,
        .cmd_per_lun            = LPFC_CMD_PER_LUN,
-       .use_clustering         = ENABLE_CLUSTERING,
        .shost_attrs            = lpfc_hba_attrs,
        .max_sectors            = 0xFFFF,
        .vendor_id              = LPFC_NL_VENDOR_ID,
@@ -6131,7 +6128,6 @@ struct scsi_host_template lpfc_vport_template = {
        .this_id                = -1,
        .sg_tablesize           = LPFC_DEFAULT_SG_SEG_CNT,
        .cmd_per_lun            = LPFC_CMD_PER_LUN,
-       .use_clustering         = ENABLE_CLUSTERING,
        .shost_attrs            = lpfc_vport_attrs,
        .max_sectors            = 0xFFFF,
        .change_queue_depth     = scsi_change_queue_depth,
index 8c71541..4862f65 100644 (file)
@@ -4148,7 +4148,6 @@ static struct scsi_host_template megaraid_template = {
        .this_id                        = DEFAULT_INITIATOR_ID,
        .sg_tablesize                   = MAX_SGLIST,
        .cmd_per_lun                    = DEF_CMD_PER_LUN,
-       .use_clustering                 = ENABLE_CLUSTERING,
        .eh_abort_handler               = megaraid_abort,
        .eh_device_reset_handler        = megaraid_reset,
        .eh_bus_reset_handler           = megaraid_reset,
index 7f9ba88..e836392 100644 (file)
@@ -336,7 +336,6 @@ static struct scsi_host_template megaraid_template_g = {
        .eh_abort_handler               = megaraid_abort_handler,
        .eh_host_reset_handler          = megaraid_reset_handler,
        .change_queue_depth             = scsi_change_queue_depth,
-       .use_clustering                 = ENABLE_CLUSTERING,
        .no_write_same                  = 1,
        .sdev_attrs                     = megaraid_sdev_attrs,
        .shost_attrs                    = megaraid_shost_attrs,
index 9db7aeb..0c72c6e 100644 (file)
@@ -3189,7 +3189,6 @@ static struct scsi_host_template megasas_template = {
        .eh_timed_out = megasas_reset_timer,
        .shost_attrs = megaraid_host_attrs,
        .bios_param = megasas_bios_param,
-       .use_clustering = ENABLE_CLUSTERING,
        .change_queue_depth = scsi_change_queue_depth,
        .no_write_same = 1,
 };
index 039dee4..22df126 100644 (file)
@@ -10173,7 +10173,6 @@ static struct scsi_host_template mpt2sas_driver_template = {
        .sg_tablesize                   = MPT2SAS_SG_DEPTH,
        .max_sectors                    = 32767,
        .cmd_per_lun                    = 7,
-       .use_clustering                 = ENABLE_CLUSTERING,
        .shost_attrs                    = mpt3sas_host_attrs,
        .sdev_attrs                     = mpt3sas_dev_attrs,
        .track_queue_depth              = 1,
@@ -10212,7 +10211,6 @@ static struct scsi_host_template mpt3sas_driver_template = {
        .sg_tablesize                   = MPT3SAS_SG_DEPTH,
        .max_sectors                    = 32767,
        .cmd_per_lun                    = 7,
-       .use_clustering                 = ENABLE_CLUSTERING,
        .shost_attrs                    = mpt3sas_host_attrs,
        .sdev_attrs                     = mpt3sas_dev_attrs,
        .track_queue_depth              = 1,
index 7d1ab41..ca96d6d 100644 (file)
@@ -78,7 +78,6 @@ static struct scsi_host_template mvme147_host_template = {
        .this_id                = 7,
        .sg_tablesize           = SG_ALL,
        .cmd_per_lun            = CMD_PER_LUN,
-       .use_clustering         = ENABLE_CLUSTERING
 };
 
 static struct Scsi_Host *mvme147_shost;
index 3ac3437..030d911 100644 (file)
@@ -59,7 +59,6 @@ static struct scsi_host_template mvs_sht = {
        .this_id                = -1,
        .sg_tablesize           = SG_ALL,
        .max_sectors            = SCSI_DEFAULT_MAX_SECTORS,
-       .use_clustering         = ENABLE_CLUSTERING,
        .eh_device_reset_handler = sas_eh_device_reset_handler,
        .eh_target_reset_handler = sas_eh_target_reset_handler,
        .target_destroy         = sas_target_destroy,
index 6cd3e28..1a236a3 100644 (file)
@@ -8313,7 +8313,6 @@ struct Scsi_Host * __init ncr_attach(struct scsi_host_template *tpnt,
        tpnt->this_id           = 7;
        tpnt->sg_tablesize      = SCSI_NCR_SG_TABLESIZE;
        tpnt->cmd_per_lun       = SCSI_NCR_CMD_PER_LUN;
-       tpnt->use_clustering    = ENABLE_CLUSTERING;
 
        if (device->differential)
                driver_setup.diff_support = device->differential;
index a3b63be..d1e98a6 100644 (file)
@@ -680,7 +680,6 @@ static struct scsi_host_template sym53c500_driver_template = {
      .can_queue                        = 1,
      .this_id                  = 7,
      .sg_tablesize             = 32,
-     .use_clustering           = ENABLE_CLUSTERING,
      .shost_attrs              = SYM53C500_shost_attrs
 };
 
index d71e7e4..a36060c 100644 (file)
@@ -84,7 +84,6 @@ static struct scsi_host_template pm8001_sht = {
        .this_id                = -1,
        .sg_tablesize           = SG_ALL,
        .max_sectors            = SCSI_DEFAULT_MAX_SECTORS,
-       .use_clustering         = ENABLE_CLUSTERING,
        .eh_device_reset_handler = sas_eh_device_reset_handler,
        .eh_target_reset_handler = sas_eh_target_reset_handler,
        .target_destroy         = sas_target_destroy,
index 707d766..7c46733 100644 (file)
@@ -4149,7 +4149,6 @@ static struct scsi_host_template pmcraid_host_template = {
        .max_sectors = PMCRAID_IOA_MAX_SECTORS,
        .no_write_same = 1,
        .cmd_per_lun = PMCRAID_MAX_CMD_PER_LUN,
-       .use_clustering = ENABLE_CLUSTERING,
        .shost_attrs = pmcraid_host_attrs,
        .proc_name = PMCRAID_DRIVER_NAME,
 };
index ee86a0c..c182b54 100644 (file)
@@ -978,7 +978,6 @@ static struct scsi_host_template ppa_template = {
        .bios_param             = ppa_biosparam,
        .this_id                = -1,
        .sg_tablesize           = SG_ALL,
-       .use_clustering         = ENABLE_CLUSTERING,
        .can_queue              = 1,
        .slave_alloc            = ppa_adjust_queue,
 };
index 4924424..8d76913 100644 (file)
@@ -349,7 +349,6 @@ static struct scsi_host_template ps3rom_host_template = {
        .sg_tablesize =         SG_ALL,
        .emulated =             1,              /* only sg driver uses this */
        .max_sectors =          PS3ROM_MAX_SECTORS,
-       .use_clustering =       ENABLE_CLUSTERING,
        .module =               THIS_MODULE,
 };
 
index 12e6e5d..edcaf4b 100644 (file)
@@ -785,7 +785,6 @@ static struct scsi_host_template qedf_host_template = {
        .name           = QEDF_MODULE_NAME,
        .this_id        = -1,
        .cmd_per_lun    = 32,
-       .use_clustering = ENABLE_CLUSTERING,
        .max_sectors    = 0xffff,
        .queuecommand   = qedf_queuecommand,
        .shost_attrs    = qedf_host_attrs,
index 2f0a4f2..4da660c 100644 (file)
@@ -61,7 +61,6 @@ struct scsi_host_template qedi_host_template = {
        .max_sectors = 0xffff,
        .dma_boundary = QEDI_HW_DMA_BOUNDARY,
        .cmd_per_lun = 128,
-       .use_clustering = ENABLE_CLUSTERING,
        .shost_attrs = qedi_shost_attrs,
 };
 
index 9c5b673..a414f51 100644 (file)
@@ -4203,7 +4203,6 @@ static struct scsi_host_template qla1280_driver_template = {
        .can_queue              = MAX_OUTSTANDING_COMMANDS,
        .this_id                = -1,
        .sg_tablesize           = SG_ALL,
-       .use_clustering         = ENABLE_CLUSTERING,
 };
 
 
index d0d3a36..90f1742 100644 (file)
@@ -328,7 +328,6 @@ struct scsi_host_template qla2xxx_driver_template = {
        .map_queues             = qla2xxx_map_queues,
        .this_id                = -1,
        .cmd_per_lun            = 3,
-       .use_clustering         = ENABLE_CLUSTERING,
        .sg_tablesize           = SG_ALL,
 
        .max_sectors            = 0xFFFF,
index 1c702cd..949e186 100644 (file)
@@ -205,7 +205,6 @@ static struct scsi_host_template qla4xxx_driver_template = {
 
        .this_id                = -1,
        .cmd_per_lun            = 3,
-       .use_clustering         = ENABLE_CLUSTERING,
        .sg_tablesize           = SG_ALL,
 
        .max_sectors            = 0xFFFF,
index 9d09228..e35ce76 100644 (file)
@@ -1287,7 +1287,6 @@ static struct scsi_host_template qpti_template = {
        .can_queue              = QLOGICPTI_REQ_QUEUE_LEN,
        .this_id                = 7,
        .sg_tablesize           = QLOGICPTI_MAX_SG(QLOGICPTI_REQ_QUEUE_LEN),
-       .use_clustering         = ENABLE_CLUSTERING,
 };
 
 static const struct of_device_id qpti_match[];
index 60bcc6d..53ba417 100644 (file)
@@ -5851,7 +5851,6 @@ static struct scsi_host_template sdebug_driver_template = {
        .sg_tablesize =         SG_MAX_SEGMENTS,
        .cmd_per_lun =          DEF_CMD_PER_LUN,
        .max_sectors =          -1U,
-       .use_clustering =       DISABLE_CLUSTERING,
        .module =               THIS_MODULE,
        .track_queue_depth =    1,
 };
@@ -5866,8 +5865,8 @@ static int sdebug_driver_probe(struct device *dev)
        sdbg_host = to_sdebug_host(dev);
 
        sdebug_driver_template.can_queue = sdebug_max_queue;
-       if (sdebug_clustering)
-               sdebug_driver_template.use_clustering = ENABLE_CLUSTERING;
+       if (!sdebug_clustering)
+               sdebug_driver_template.use_clustering = DISABLE_CLUSTERING;
        hpnt = scsi_host_alloc(&sdebug_driver_template, sizeof(sdbg_host));
        if (NULL == hpnt) {
                pr_err("scsi_host_alloc failed\n");
index c7fccbb..f6900e0 100644 (file)
@@ -2229,7 +2229,7 @@ void __scsi_init_queue(struct Scsi_Host *shost, struct request_queue *q)
 
        blk_queue_max_segment_size(q, dma_get_max_seg_size(dev));
 
-       if (!shost->use_clustering)
+       if (shost->use_clustering == DISABLE_CLUSTERING)
                q->limits.cluster = 0;
 
        /*
index a25a07a..c9a1a49 100644 (file)
@@ -5779,7 +5779,6 @@ static struct scsi_host_template pqi_driver_template = {
        .scan_start = pqi_scan_start,
        .scan_finished = pqi_scan_finished,
        .this_id = -1,
-       .use_clustering = ENABLE_CLUSTERING,
        .eh_device_reset_handler = pqi_eh_device_reset_handler,
        .ioctl = pqi_ioctl,
        .slave_alloc = pqi_slave_alloc,
index 5295277..5e824fd 100644 (file)
@@ -127,7 +127,6 @@ static struct scsi_host_template snic_host_template = {
        .this_id = -1,
        .cmd_per_lun = SNIC_DFLT_QUEUE_DEPTH,
        .can_queue = SNIC_MAX_IO_REQ,
-       .use_clustering = ENABLE_CLUSTERING,
        .sg_tablesize = SNIC_MAX_SG_DESC_CNT,
        .max_sectors = 0x800,
        .shost_attrs = snic_attrs,
index f03dc03..8ab05e9 100644 (file)
@@ -1698,7 +1698,6 @@ static struct scsi_host_template scsi_driver = {
        .slave_configure =      storvsc_device_configure,
        .cmd_per_lun =          2048,
        .this_id =              -1,
-       .use_clustering =       ENABLE_CLUSTERING,
        /* Make sure we dont get a sg segment crosses a page boundary */
        .dma_boundary =         PAGE_SIZE-1,
        .no_write_same =        1,
index 6e9b540..57f6d63 100644 (file)
@@ -1660,7 +1660,6 @@ static struct scsi_host_template sym2_template = {
        .eh_bus_reset_handler   = sym53c8xx_eh_bus_reset_handler,
        .eh_host_reset_handler  = sym53c8xx_eh_host_reset_handler,
        .this_id                = 7,
-       .use_clustering         = ENABLE_CLUSTERING,
        .max_sectors            = 0xFFFF,
 #ifdef SYM_LINUX_PROC_INFO_SUPPORT
        .show_info              = sym_show_info,
index 198af63..82455c4 100644 (file)
@@ -697,7 +697,6 @@ static struct scsi_host_template virtscsi_host_template = {
        .slave_alloc = virtscsi_device_alloc,
 
        .dma_boundary = UINT_MAX,
-       .use_clustering = ENABLE_CLUSTERING,
        .map_queues = virtscsi_map_queues,
        .track_queue_depth = 1,
        .force_blk_mq = 1,
index 6e49102..644b0e1 100644 (file)
@@ -1007,7 +1007,6 @@ static struct scsi_host_template pvscsi_template = {
        .sg_tablesize                   = PVSCSI_MAX_NUM_SG_ENTRIES_PER_SEGMENT,
        .dma_boundary                   = UINT_MAX,
        .max_sectors                    = 0xffff,
-       .use_clustering                 = ENABLE_CLUSTERING,
        .change_queue_depth             = pvscsi_change_queue_depth,
        .eh_abort_handler               = pvscsi_abort,
        .eh_device_reset_handler        = pvscsi_device_reset,
index 808ba8e..e3310e9 100644 (file)
@@ -871,7 +871,6 @@ static struct scsi_host_template wd719x_template = {
        .can_queue                      = 255,
        .this_id                        = 7,
        .sg_tablesize                   = WD719X_SG,
-       .use_clustering                 = ENABLE_CLUSTERING,
 };
 
 static int wd719x_pci_probe(struct pci_dev *pdev, const struct pci_device_id *d)
index 69e6abe..c57d66a 100644 (file)
@@ -237,12 +237,6 @@ static struct scsi_host_template rtsx_host_template = {
        /* limit the total size of a transfer to 120 KB */
        .max_sectors =                  240,
 
-       /* merge commands... this seems to help performance, but
-        * periodically someone should test to see which setting is more
-        * optimal.
-        */
-       .use_clustering =               1,
-
        /* emulated HBA */
        .emulated =                     1,
 
index 4fc521c..5cf93e8 100644 (file)
@@ -645,7 +645,6 @@ static struct scsi_host_template visorhba_driver_template = {
        .this_id = -1,
        .slave_alloc = visorhba_slave_alloc,
        .slave_destroy = visorhba_slave_destroy,
-       .use_clustering = ENABLE_CLUSTERING,
 };
 
 /*
index 9f2f563..607be1f 100644 (file)
@@ -632,7 +632,6 @@ static struct scsi_host_template mts_scsi_host_template = {
        .sg_tablesize =         SG_ALL,
        .can_queue =            1,
        .this_id =              -1,
-       .use_clustering =       1,
        .emulated =             1,
        .slave_alloc =          mts_slave_alloc,
        .slave_configure =      mts_slave_configure,
index e227bb5..fde2e71 100644 (file)
@@ -639,13 +639,6 @@ static const struct scsi_host_template usb_stor_host_template = {
         */
        .max_sectors =                  240,
 
-       /*
-        * merge commands... this seems to help performance, but
-        * periodically someone should test to see which setting is more
-        * optimal.
-        */
-       .use_clustering =               1,
-
        /* emulated HBA */
        .emulated =                     1,
 
index 38c95d6..6813384 100644 (file)
@@ -135,7 +135,6 @@ enum {
 
        ATA_SHT_EMULATED        = 1,
        ATA_SHT_THIS_ID         = -1,
-       ATA_SHT_USE_CLUSTERING  = 1,
 
        /* struct ata_taskfile flags */
        ATA_TFLAG_LBA48         = (1 << 0), /* enable 48-bit LBA and "HOB" */
@@ -1360,7 +1359,6 @@ extern struct device_attribute *ata_common_sdev_attrs[];
        .tag_alloc_policy       = BLK_TAG_ALLOC_RR,             \
        .this_id                = ATA_SHT_THIS_ID,              \
        .emulated               = ATA_SHT_EMULATED,             \
-       .use_clustering         = ATA_SHT_USE_CLUSTERING,       \
        .proc_name              = drv_name,                     \
        .slave_configure        = ata_scsi_slave_config,        \
        .slave_destroy          = ata_scsi_slave_destroy,       \
index 5ea06d3..7dc534c 100644 (file)
@@ -44,8 +44,7 @@ struct blk_queue_tags;
 #define MODE_INITIATOR 0x01
 #define MODE_TARGET 0x02
 
-#define DISABLE_CLUSTERING 0
-#define ENABLE_CLUSTERING 1
+#define DISABLE_CLUSTERING (-1)
 
 struct scsi_host_template {
        struct module *module;