OSDN Git Service

staging: erofs: code cleanup for erofs_show_options()
authorChengguang Xu <cgxu519@gmx.com>
Wed, 19 Sep 2018 14:53:45 +0000 (22:53 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 20 Sep 2018 10:26:29 +0000 (12:26 +0200)
Add new helper erofs_get_fault_rate() to get fault rate instead of
directly getting it from sbi, so we can remove the macro check
surrounding it.

Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Reviewed-by: Gao Xiang <gaoxiang25@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/erofs/super.c

index b4d33a7..d5a6106 100644 (file)
@@ -165,6 +165,11 @@ static int erofs_build_fault_attr(struct erofs_sb_info *sbi,
        set_opt(sbi, FAULT_INJECTION);
        return 0;
 }
+
+static unsigned int erofs_get_fault_rate(struct erofs_sb_info *sbi)
+{
+       return sbi->fault_info.inject_rate;
+}
 #else
 static int erofs_build_fault_attr(struct erofs_sb_info *sbi,
                                  substring_t *args)
@@ -172,6 +177,11 @@ static int erofs_build_fault_attr(struct erofs_sb_info *sbi,
        infoln("fault_injection options not supported");
        return 0;
 }
+
+static unsigned int erofs_get_fault_rate(struct erofs_sb_info *sbi)
+{
+       return 0;
+}
 #endif
 
 static void default_options(struct erofs_sb_info *sbi)
@@ -631,11 +641,9 @@ static int erofs_show_options(struct seq_file *seq, struct dentry *root)
        else
                seq_puts(seq, ",noacl");
 #endif
-#ifdef CONFIG_EROFS_FAULT_INJECTION
        if (test_opt(sbi, FAULT_INJECTION))
                seq_printf(seq, ",fault_injection=%u",
-                               sbi->fault_info.inject_rate);
-#endif
+                       erofs_get_fault_rate(sbi));
        return 0;
 }