OSDN Git Service

iio: accel: bma220: Use BIT() and GENMASK() macros
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 31 Aug 2020 09:08:12 +0000 (12:08 +0300)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Thu, 3 Sep 2020 18:41:00 +0000 (19:41 +0100)
Code is better to read when numbers of bit are explicitly used.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20200831090813.78841-7-andriy.shevchenko@linux.intel.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/accel/bma220_spi.c

index 73927f9..efdf22e 100644 (file)
@@ -5,6 +5,7 @@
  * Copyright (c) 2016, Intel Corporation.
  */
 
+#include <linux/bits.h>
 #include <linux/kernel.h>
 #include <linux/mod_devicetable.h>
 #include <linux/module.h>
@@ -24,8 +25,8 @@
 #define BMA220_REG_SUSPEND                     0x18
 
 #define BMA220_CHIP_ID                         0xDD
-#define BMA220_READ_MASK                       0x80
-#define BMA220_RANGE_MASK                      0x03
+#define BMA220_READ_MASK                       BIT(7)
+#define BMA220_RANGE_MASK                      GENMASK(1, 0)
 #define BMA220_DATA_SHIFT                      2
 #define BMA220_SUSPEND_SLEEP                   0xFF
 #define BMA220_SUSPEND_WAKE                    0x00