OSDN Git Service

i3c: master: dw: fix mask operation by using the correct operator
authorColin Ian King <colin.king@canonical.com>
Fri, 16 Nov 2018 18:42:23 +0000 (18:42 +0000)
committerBoris Brezillon <boris.brezillon@bootlin.com>
Wed, 5 Dec 2018 16:22:58 +0000 (17:22 +0100)
The masking operation on status is using a bitwise 'or' rather than
a bitwise 'and' operator, and hence the result is always non-zero
which is probably not what is intended. Fix this by using the correct
operator.

Detected by CoverityScan, CID#1475523 ("Wrong operator used")

Fixes: 88acc98a712a ("i3c: master: Add driver for Synopsys DesignWare IP")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Vitor Soares <vitor.soares@synopsys.com>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
drivers/i3c/master/dw-i3c-master.c

index 0153e6e..b532e2c 100644 (file)
@@ -1085,7 +1085,7 @@ static irqreturn_t dw_i3c_master_irq_handler(int irq, void *dev_id)
 
        spin_lock(&master->xferqueue.lock);
        dw_i3c_master_end_xfer_locked(master, status);
-       if (status | INTR_TRANSFER_ERR_STAT)
+       if (status & INTR_TRANSFER_ERR_STAT)
                writel(INTR_TRANSFER_ERR_STAT, master->regs + INTR_STATUS);
        spin_unlock(&master->xferqueue.lock);