OSDN Git Service

net: phy: dp83867: Set up RGMII TX delay
authorMax Uvarov <muvarov@gmail.com>
Tue, 28 May 2019 10:00:52 +0000 (13:00 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 29 May 2019 21:28:48 +0000 (14:28 -0700)
PHY_INTERFACE_MODE_RGMII_RXID is less then TXID
so code to set tx delay is never called.

Fixes: 2a10154abcb75 ("net: phy: dp83867: Add TI dp83867 phy")
Signed-off-by: Max Uvarov <muvarov@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/dp83867.c

index 1ec48ec..c71c7d0 100644 (file)
@@ -255,10 +255,8 @@ static int dp83867_config_init(struct phy_device *phydev)
                ret = phy_write(phydev, MII_DP83867_PHYCTRL, val);
                if (ret)
                        return ret;
-       }
 
-       if ((phydev->interface >= PHY_INTERFACE_MODE_RGMII_ID) &&
-           (phydev->interface <= PHY_INTERFACE_MODE_RGMII_RXID)) {
+               /* Set up RGMII delays */
                val = phy_read_mmd(phydev, DP83867_DEVADDR, DP83867_RGMIICTL);
 
                if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID)